On Mon Apr 28 01:13:32 2025 +0300, Laurent Pinchart wrote:
> When the VT tree calculation fails to find a valid pre-divider, the
> ccs_pll_calculate_vt_tree() function returns an error silently, and the
> caller doesn't print any message either. This makes debugging PLL
> calculation issues more difficult. Add a debug message to report the
> issue, and amend the corresponding message for the OP tree to mention
> "OP".
>
> Signed-off-by: Laurent Pinchart <[email protected]>
> Signed-off-by: Sakari Ailus <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>
Patch committed.
Thanks,
Hans Verkuil
drivers/media/i2c/ccs-pll.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/drivers/media/i2c/ccs-pll.c b/drivers/media/i2c/ccs-pll.c
index 8f9a695bd9e5..4eb83636e102 100644
--- a/drivers/media/i2c/ccs-pll.c
+++ b/drivers/media/i2c/ccs-pll.c
@@ -449,6 +449,7 @@ static int ccs_pll_calculate_vt_tree(struct device *dev,
return 0;
}
+ dev_dbg(dev, "unable to compute VT pre_pll divisor\n");
return -EINVAL;
}
@@ -888,8 +889,7 @@ int ccs_pll_calculate(struct device *dev, const struct
ccs_pll_limits *lim,
}
if (rval) {
- dev_dbg(dev, "unable to compute pre_pll divisor\n");
-
+ dev_dbg(dev, "unable to compute OP pre_pll divisor\n");
return rval;
}
