On Mon Jun 16 09:18:52 2025 +0200, Bartosz Golaszewski wrote:
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. Convert the driver to using
> them.
> 
> Signed-off-by: Bartosz Golaszewski <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/pci/solo6x10/solo6x10-gpio.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

---

diff --git a/drivers/media/pci/solo6x10/solo6x10-gpio.c 
b/drivers/media/pci/solo6x10/solo6x10-gpio.c
index f51f865c69bd..b16a8453a62a 100644
--- a/drivers/media/pci/solo6x10/solo6x10-gpio.c
+++ b/drivers/media/pci/solo6x10/solo6x10-gpio.c
@@ -127,8 +127,8 @@ static int solo_gpiochip_get(struct gpio_chip *chip,
        return 1 & (ret >> (offset + 8));
 }
 
-static void solo_gpiochip_set(struct gpio_chip *chip,
-                                               unsigned int offset, int value)
+static int solo_gpiochip_set(struct gpio_chip *chip,
+                            unsigned int offset, int value)
 {
        struct solo_dev *solo_dev = gpiochip_get_data(chip);
 
@@ -136,6 +136,8 @@ static void solo_gpiochip_set(struct gpio_chip *chip,
                solo_gpio_set(solo_dev, 1 << (offset + 8));
        else
                solo_gpio_clear(solo_dev, 1 << (offset + 8));
+
+       return 0;
 }
 #endif
 
@@ -156,7 +158,7 @@ int solo_gpio_init(struct solo_dev *solo_dev)
 
        solo_dev->gpio_dev.get_direction = solo_gpiochip_get_direction;
        solo_dev->gpio_dev.get = solo_gpiochip_get;
-       solo_dev->gpio_dev.set = solo_gpiochip_set;
+       solo_dev->gpio_dev.set_rv = solo_gpiochip_set;
 
        ret = gpiochip_add_data(&solo_dev->gpio_dev, solo_dev);
 

Reply via email to