[media.git/next] media: nxp: imx8-isi: Use dev_err_probe() to simplify code

[media-ci]

On Thu May 22 13:56:44 2025 -0400, Frank Li wrote:
> Use dev_err_probe() simplify code. No functional changes intended.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Signed-off-by: Frank Li <frank...@nxp.com>
> Link: https://lore.kernel.org/r/20250522-8qxp_camera-v5-6-d4be869fd...@nxp.com
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

---

diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c 
b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
index 073ea5912de3..4ab2749e460d 100644
--- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
+++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
@@ -428,19 +428,16 @@ static int mxc_isi_probe(struct platform_device *pdev)
                return dev_err_probe(dev, isi->num_clks, "Failed to get 
clocks\n");
 
        isi->regs = devm_platform_ioremap_resource(pdev, 0);
-       if (IS_ERR(isi->regs)) {
-               dev_err(dev, "Failed to get ISI register map\n");
-               return PTR_ERR(isi->regs);
-       }
+       if (IS_ERR(isi->regs))
+               return dev_err_probe(dev, PTR_ERR(isi->regs),
+                                    "Failed to get ISI register map\n");
 
        if (isi->pdata->gasket_ops) {
                isi->gasket = syscon_regmap_lookup_by_phandle(dev->of_node,
                                                              "fsl,blk-ctrl");
-               if (IS_ERR(isi->gasket)) {
-                       ret = PTR_ERR(isi->gasket);
-                       dev_err(dev, "failed to get gasket: %d\n", ret);
-                       return ret;
-               }
+               if (IS_ERR(isi->gasket))
+                       return dev_err_probe(dev, PTR_ERR(isi->gasket),
+                                            "failed to get gasket\n");
        }
 
        dma_size = isi->pdata->has_36bit_dma ? 36 : 32;