On Fri Jun 13 09:15:57 2025 +0200, Krzysztof Kozlowski wrote:
> It is very useful to find driver implementing compatibles with `git grep
> compatible`, so driver should not use defines for that string, even if
> this means string will be effectively duplicated.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org>
> Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c | 2 +-
 drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.h | 2 --
 drivers/media/platform/samsung/exynos4-is/fimc-is.c     | 2 +-
 3 files changed, 2 insertions(+), 4 deletions(-)

---

diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c 
b/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c
index b243cbb1d010..b5b37b6f8fa8 100644
--- a/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c
+++ b/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c
@@ -131,7 +131,7 @@ static const struct dev_pm_ops fimc_is_i2c_pm_ops = {
 };
 
 static const struct of_device_id fimc_is_i2c_of_match[] = {
-       { .compatible = FIMC_IS_I2C_COMPATIBLE },
+       { .compatible = "samsung,exynos4212-i2c-isp" },
        { },
 };
 
diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.h 
b/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.h
index a23bd20be6c8..69d597e5c297 100644
--- a/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.h
+++ b/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.h
@@ -6,7 +6,5 @@
  * Sylwester Nawrocki <s.nawro...@samsung.com>
  */
 
-#define FIMC_IS_I2C_COMPATIBLE "samsung,exynos4212-i2c-isp"
-
 int fimc_is_register_i2c_driver(void);
 void fimc_is_unregister_i2c_driver(void);
diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-is.c 
b/drivers/media/platform/samsung/exynos4-is/fimc-is.c
index 2e8fe9e49735..ed7b7ca16f71 100644
--- a/drivers/media/platform/samsung/exynos4-is/fimc-is.c
+++ b/drivers/media/platform/samsung/exynos4-is/fimc-is.c
@@ -207,7 +207,7 @@ static int fimc_is_register_subdevs(struct fimc_is *is)
        if (ret < 0)
                return ret;
 
-       for_each_compatible_node(i2c_bus, NULL, FIMC_IS_I2C_COMPATIBLE) {
+       for_each_compatible_node(i2c_bus, NULL, "samsung,exynos4212-i2c-isp") {
                for_each_available_child_of_node(i2c_bus, child) {
                        ret = fimc_is_parse_sensor_config(is, index, child);
 

Reply via email to