On Fri May 9 09:58:09 2025 +0200, Krzysztof HaÅasa wrote:
> The error messages in the mxc_isi_crossbar_enable_streams() and
> mxc_isi_crossbar_disable_streams() functions are similar, with a single
> word difference between them. The word is moved out of the format string
> to a separate dev_err() argument to try and save memory through string
> de-duplication. The total savings are however small, as the .data size
> reduction is partly offset by a .text size increase, with a total saving
> of 8 bytes in total on an ARM64 platforms. They also come at the cost of
> making the error message difficult to grep, which outweights the gains.
>
> Simplify the error messages to make them grep-able.
>
> Signed-off-by: Krzysztof HaÅasa <[email protected]>
> Reviewed-by: Laurent Pinchart <[email protected]>
> Link: https://lore.kernel.org/r/[email protected]
> Signed-off-by: Laurent Pinchart <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>
Patch committed.
Thanks,
Hans Verkuil
drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
---
diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
index 93a55c97cd17..b6c7f114f9ed 100644
--- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
+++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
@@ -352,9 +352,8 @@ static int mxc_isi_crossbar_enable_streams(struct
v4l2_subdev *sd,
sink_streams);
if (ret) {
dev_err(xbar->isi->dev,
- "failed to %s streams 0x%llx on '%s':%u: %d\n",
- "enable", sink_streams, remote_sd->name,
- remote_pad, ret);
+ "failed to enable streams 0x%llx on '%s':%u:
%d\n",
+ sink_streams, remote_sd->name, remote_pad, ret);
mxc_isi_crossbar_gasket_disable(xbar, sink_pad);
return ret;
}
@@ -392,9 +391,8 @@ static int mxc_isi_crossbar_disable_streams(struct
v4l2_subdev *sd,
sink_streams);
if (ret)
dev_err(xbar->isi->dev,
- "failed to %s streams 0x%llx on '%s':%u: %d\n",
- "disable", sink_streams, remote_sd->name,
- remote_pad, ret);
+ "failed to disable streams 0x%llx on '%s':%u:
%d\n",
+ sink_streams, remote_sd->name, remote_pad, ret);
mxc_isi_crossbar_gasket_disable(xbar, sink_pad);
}
