Dear Sakari Ailus:
Thanks for your patches! Unfortunately the Media CI robot detected some
issues:
# Test static:test-smatch
drivers/media/i2c/imx214.c:1109 imx214_ctrls_init() error: we previously
assumed 'imx214->link_freq' could be null (see line 1017)
# Test
checkpatch:./0022-media-rzg2l-cru-Drop-function-pointer-to-configure-C.patch
checkpatch
CHECK: Avoid CamelCase: <ICnSVC>
#105: FILE: drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:267:
+if (cru->info->regs[ICnSVC]) {
CHECK: Avoid CamelCase: <ICnSVCNUM>
#106: FILE: drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:268:
+rzg2l_cru_write(cru, ICnSVCNUM, csi_vc);
CHECK: Avoid CamelCase: <ICnSVC_SVC0>
#107: FILE: drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:269:
+rzg2l_cru_write(cru, ICnSVC, ICnSVC_SVC0(0) | ICnSVC_SVC1(1) |
CHECK: Avoid CamelCase: <ICnSVC_SVC1>
#107: FILE: drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:269:
+rzg2l_cru_write(cru, ICnSVC, ICnSVC_SVC0(0) | ICnSVC_SVC1(1) |
CHECK: Avoid CamelCase: <ICnSVC_SVC2>
#108: FILE: drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:270:
+ICnSVC_SVC2(2) | ICnSVC_SVC3(3));
CHECK: Avoid CamelCase: <ICnSVC_SVC3>
#108: FILE: drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:270:
+ICnSVC_SVC2(2) | ICnSVC_SVC3(3));
total: 0 errors, 0 warnings, 6 checks, 80 lines checked
# Test
checkpatch:./0032-media-v4l2-subdev-Fix-alloc-failure-check-in-v4l2_su.patch
checkpatch
CHECK: Macro argument reuse 'sd' - possible side-effects?
#46: FILE: include/media/v4l2-subdev.h:1942:
+#define v4l2_subdev_call_state_try(sd, o, f, args...) \
+({ \
+int __result; \
+static struct lock_class_key __key; \
+const char *name = KBUILD_BASENAME \
+":" __stringify(__LINE__) ":state->lock"; \
+struct v4l2_subdev_state *state = \
+__v4l2_subdev_state_alloc(sd, name, &__key); \
+if (IS_ERR(state)) { \
+__result = PTR_ERR(state); \
+} else { \
+v4l2_subdev_lock_state(state); \
+__result = v4l2_subdev_call(sd, o, f, state, ##args); \
+v4l2_subdev_unlock_state(state); \
+__v4l2_subdev_state_free(state); \
+} \
+__result; \
})
total: 0 errors, 0 warnings, 1 checks, 36 lines checked
Please fix your series, and upload a new version. If you have a patchwork
account, do not forget to mark the current series as Superseded.
For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/83048840/artifacts/report.htm
.
Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.
---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
to this message.
