This is an automatic generated email to let you know that the following patch were queued at the http://git.linuxtv.org/cgit.cgi/v4l-utils.git tree:
Subject: v4l2-ctl: do not fail on kernel not implementing VIDIOC_SUBDEV_QUERYCAP Author: Quentin Schulz <[email protected]> Date: Tue Oct 7 15:40:04 2025 +0200 The comment above the code snippet specifies that we do not want to fail on kernels not implementing VIDIOC_SUBDEV_QUERYCAP (5.9 and earlier) but calling doioctl will still set app_result to a negative value if the kernel doesn't implement it (this ioctl returning -1 with errno set to ENOTTY). Considering app_result is used as the exit code of the program, ignoring the return value of doioctl function is not enough to make this ioctl truly optional. Let's handle this ioctl as optional to avoid kernels lacking it making v4l2-ctl command fail (but still doing what it's been asked to do) by calling test_ioctl directly. Fixes: fc89f67d9fe0 ("v4l2-ctl: add support for VIDIOC_SUBDEV_QUERYCAP") Signed-off-by: Quentin Schulz <[email protected]> Signed-off-by: Hans Verkuil <[email protected]> utils/v4l2-ctl/v4l2-ctl.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=54ad63a39810c4134d84255596d231dc82ab84ed diff --git a/utils/v4l2-ctl/v4l2-ctl.cpp b/utils/v4l2-ctl/v4l2-ctl.cpp index 17c262fc88da..842e22fd939a 100644 --- a/utils/v4l2-ctl/v4l2-ctl.cpp +++ b/utils/v4l2-ctl/v4l2-ctl.cpp @@ -1369,7 +1369,7 @@ int main(int argc, char **argv) } else if (is_subdev) { // This ioctl was introduced in kernel 5.10, so don't // exit if this ioctl returns an error. - doioctl(fd, VIDIOC_SUBDEV_QUERYCAP, &subdevcap); + test_ioctl(fd, VIDIOC_SUBDEV_QUERYCAP, &subdevcap); subdevclientcap.capabilities = ~0ULL; // This ioctl was introduced in kernel 6.4, so don't // exit if this ioctl returns an error. _______________________________________________ linuxtv-commits mailing list -- [email protected] To unsubscribe send an email to [email protected]
