On Wed Oct 15 10:53:29 2025 +0300, Laurent Pinchart wrote:
> The v4l2_m2m_get_vq() function never returns NULL.
>
> In e5010_s_fmt(), the check may have been intended to catch invalid
> format types, but that's not needed as the V4L2 core picks the
> appropriate VIDIOC_S_FMT ioctl handler based on the format type, so the
> type can't be incorrect.
>
> In e5010_s_selection(), the function performs an explicit type check, so
> the NULL check couldn't have been intended as a type check.
>
> Drop the unneeded return value check.
>
> Signed-off-by: Laurent Pinchart <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>
Patch committed.
Thanks,
Hans Verkuil
drivers/media/platform/imagination/e5010-jpeg-enc.c | 4 ----
1 file changed, 4 deletions(-)
---
diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.c
b/drivers/media/platform/imagination/e5010-jpeg-enc.c
index c4e0097cb8b7..1b5c8b1d6a31 100644
--- a/drivers/media/platform/imagination/e5010-jpeg-enc.c
+++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c
@@ -396,8 +396,6 @@ static int e5010_s_fmt(struct file *file, void *priv,
struct v4l2_format *f)
struct e5010_fmt *fmt;
vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, f->type);
- if (!vq)
- return -EINVAL;
if (vb2_is_busy(vq)) {
v4l2_err(&ctx->e5010->v4l2_dev, "queue busy\n");
@@ -496,8 +494,6 @@ static int e5010_s_selection(struct file *file, void *fh,
struct v4l2_selection
struct v4l2_rect base_rect;
vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, s->type);
- if (!vq)
- return -EINVAL;
if (vb2_is_streaming(vq))
return -EBUSY;
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
