On Mon Oct 13 14:15:02 2025 +0000, Ricardo Ribalda wrote:
> The %pe format specifier is designed to print error pointers. It prints
> a symbolic error name (eg. -EINVAL) and it makes the code simpler by
> omitting PTR_ERR().
> 
> This patch fixes this cocci report:
> ./pci/intel/ipu3/ipu3-cio2.c:318:19-26: WARNING: Consider using %pe to print 
> PTR_ERR()
> 
> Signed-off-by: Ricardo Ribalda <[email protected]>
> Acked-by: Sakari Ailus <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/pci/intel/ipu3/ipu3-cio2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

---

diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c 
b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
index a87f105beb5e..986b9afd7cb5 100644
--- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
+++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
@@ -314,8 +314,8 @@ static int cio2_csi2_calc_timing(struct cio2_device *cio2, 
struct cio2_queue *q,
 
        src_pad = media_entity_remote_source_pad_unique(&q->subdev.entity);
        if (IS_ERR(src_pad)) {
-               dev_err(dev, "can't get source pad of %s (%ld)\n",
-                       q->subdev.name, PTR_ERR(src_pad));
+               dev_err(dev, "can't get source pad of %s (%pe)\n",
+                       q->subdev.name, src_pad);
                return PTR_ERR(src_pad);
        }
 
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to