On Tue Apr 7 01:14:40 2026 +0300, Samuel Holland wrote:
> If V4L2 device fails to register, then SRAM still be claimed and as a
> result driver will not be able to probe again.
>
> cedrus 1c0e000.video-codec: Failed to claim SRAM
> cedrus 1c0e000.video-codec: Failed to probe hardware
> cedrus 1c0e000.video-codec: probe with driver cedrus failed with error -16
>
> cedrus_hw_remove undoes everything that was previously done by
> cedrus_hw_probe, such as disabling runtime power management and
> releasing the claimed SRAM and reserved memory region.
>
> Signed-off-by: Samuel Holland <[email protected]>
> Signed-off-by: Andrey Skvortsov <[email protected]>
> Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver")
> Acked-by: Paul Kocialkowski <[email protected]>
> Signed-off-by: Nicolas Dufresne <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>
Patch committed.
Thanks,
Hans Verkuil
drivers/staging/media/sunxi/cedrus/cedrus.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c
b/drivers/staging/media/sunxi/cedrus/cedrus.c
index 1d2130f35fff..ee0e286add67 100644
--- a/drivers/staging/media/sunxi/cedrus/cedrus.c
+++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
@@ -477,7 +477,7 @@ static int cedrus_probe(struct platform_device *pdev)
ret = v4l2_device_register(&pdev->dev, &dev->v4l2_dev);
if (ret) {
dev_err(&pdev->dev, "Failed to register V4L2 device\n");
- return ret;
+ goto err_hw;
}
vfd = &dev->vfd;
@@ -538,6 +538,8 @@ err_m2m:
v4l2_m2m_release(dev->m2m_dev);
err_v4l2:
v4l2_device_unregister(&dev->v4l2_dev);
+err_hw:
+ cedrus_hw_remove(dev);
return ret;
}
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
