Dear Nicolas Dufresne: Thanks for your patches! Unfortunately the Media CI robot detected some issues:
# Test media-patchstyle:./0001-media-verisilicon-Create-AV1-helper-library.patch media style ERROR: ./0001-media-verisilicon-Create-AV1-helper-library.patch: Missing committer Ricardo Ribalda <[email protected]> Signed-off-by # Test checkpatch:./0001-media-verisilicon-Create-AV1-helper-library.patch checkpatch WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: rename drivers/media/platform/verisilicon/{rockchip_av1_entropymode.c => hantro_av1_entropymode.c} (99%) WARNING: line length of 103 exceeds 100 columns #460: FILE: drivers/media/platform/verisilicon/hantro_av1.c:395: + ALIGN(sizeof(struct hantro_av1_film_grain), 2048), WARNING: line length of 104 exceeds 100 columns #611: FILE: drivers/media/platform/verisilicon/hantro_av1.c:546: +hantro_av1_get_shear_params(&gm->params[V4L2_AV1_REF_LAST_FRAME + ref_frame][0], ERROR: trailing statements should be on next line #633: FILE: drivers/media/platform/verisilicon/hantro_av1.c:568: +for (k = 0; (1 << k) < target; k++); WARNING: function definition argument 's32' should also have an identifier name #1201: FILE: drivers/media/platform/verisilicon/hantro_av1_filmgrain.h:16: +void hantro_av1_generate_luma_grain_block(s32 (*luma_grain_block)[73][82], WARNING: function definition argument 's32' should also have an identifier name #1201: FILE: drivers/media/platform/verisilicon/hantro_av1_filmgrain.h:16: +void hantro_av1_generate_luma_grain_block(s32 (*luma_grain_block)[73][82], WARNING: function definition argument 's32' should also have an identifier name #1212: FILE: drivers/media/platform/verisilicon/hantro_av1_filmgrain.h:27: +void hantro_av1_generate_chroma_grain_block(s32 (*luma_grain_block)[73][82], WARNING: function definition argument 's32' should also have an identifier name #1212: FILE: drivers/media/platform/verisilicon/hantro_av1_filmgrain.h:27: +void hantro_av1_generate_chroma_grain_block(s32 (*luma_grain_block)[73][82], WARNING: function definition argument 's32' should also have an identifier name #1212: FILE: drivers/media/platform/verisilicon/hantro_av1_filmgrain.h:27: +void hantro_av1_generate_chroma_grain_block(s32 (*luma_grain_block)[73][82], WARNING: function definition argument 's32' should also have an identifier name #1212: FILE: drivers/media/platform/verisilicon/hantro_av1_filmgrain.h:27: +void hantro_av1_generate_chroma_grain_block(s32 (*luma_grain_block)[73][82], WARNING: function definition argument 's32' should also have an identifier name #1212: FILE: drivers/media/platform/verisilicon/hantro_av1_filmgrain.h:27: +void hantro_av1_generate_chroma_grain_block(s32 (*luma_grain_block)[73][82], total: 1 errors, 10 warnings, 0 checks, 2379 lines checked Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded. For more details, check the full report at: https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/99166171/artifacts/report.htm . Best regards, and Happy Hacking! Media CI robot on behalf of the linux-media community. --- Check the latest rules for contributing your patches at: https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html If you believe that the CI is wrong, kindly open an issue at https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all to this message. _______________________________________________ linuxtv-commits mailing list -- [email protected] To unsubscribe send an email to [email protected]
