On Fri Apr 17 14:53:30 2026 +0800, Guangshuo Li wrote:
> During manual code audit, we found that cafe_pci_probe() enables the
> PCI device with pci_enable_device(), and its probe error path properly
> calls pci_disable_device() on failure.
>
> However, cafe_pci_remove() tears down the controller and frees the
> driver data without disabling the PCI device, leaving the remove path
> inconsistent with probe cleanup.
>
> Add the missing pci_disable_device() call to cafe_pci_remove().
>
> Fixes: abfa3df36c01 ("[media] marvell-cam: Separate out the Marvell camera
> core")
> Cc: [email protected]
> Signed-off-by: Guangshuo Li <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>
Patch committed.
Thanks,
Hans Verkuil
drivers/media/platform/marvell/cafe-driver.c | 1 +
1 file changed, 1 insertion(+)
---
diff --git a/drivers/media/platform/marvell/cafe-driver.c
b/drivers/media/platform/marvell/cafe-driver.c
index 632c15572aa8..22034df6cba9 100644
--- a/drivers/media/platform/marvell/cafe-driver.c
+++ b/drivers/media/platform/marvell/cafe-driver.c
@@ -609,6 +609,7 @@ static void cafe_pci_remove(struct pci_dev *pdev)
return;
}
cafe_shutdown(cam);
+ pci_disable_device(pdev);
kfree(cam);
}
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
