Dear Jacopo Mondi: Thanks for your patches! Unfortunately the Media CI robot detected some issues:
# Test media-patchstyle:./0001-media-rzg2l-cru-Skip-ICnMC-configuration-when-ICnSVC.patch media style ERROR: ./0001-media-rzg2l-cru-Skip-ICnMC-configuration-when-ICnSVC.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0002-media-rzg2l-cru-Use-only-frame-end-interrupts.patch media style ERROR: ./0002-media-rzg2l-cru-Use-only-frame-end-interrupts.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0003-media-rzg2l-cru-Modernize-locking-usage-with-guards.patch media style ERROR: ./0003-media-rzg2l-cru-Modernize-locking-usage-with-guards.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0004-media-rzg2l-cru-Use-proper-guard-in-irq-handler.patch media style ERROR: ./0004-media-rzg2l-cru-Use-proper-guard-in-irq-handler.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0005-media-rzg2l-cru-Remove-locking-from-start-stop-routi.patch media style ERROR: ./0005-media-rzg2l-cru-Remove-locking-from-start-stop-routi.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0006-media-rzg2l-cru-Do-not-use-irqsave-when-not-needed.patch media style ERROR: ./0006-media-rzg2l-cru-Do-not-use-irqsave-when-not-needed.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0007-media-rzg2l-cru-Remove-wrong-locking-comment.patch media style ERROR: ./0007-media-rzg2l-cru-Remove-wrong-locking-comment.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0008-media-rz2gl-cru-Introduce-a-spinlock-for-hw-operatio.patch media style ERROR: ./0008-media-rz2gl-cru-Introduce-a-spinlock-for-hw-operatio.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0009-media-rzg2l-cru-Split-hw-locking-from-buffers.patch media style ERROR: ./0009-media-rzg2l-cru-Split-hw-locking-from-buffers.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0010-media-rzg2l-cru-Manually-track-active-slot-number.patch media style ERROR: ./0010-media-rzg2l-cru-Manually-track-active-slot-number.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0011-media-rz2gl-cru-Return-pending-buffers-in-order.patch media style ERROR: ./0011-media-rz2gl-cru-Return-pending-buffers-in-order.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0012-media-rzg2l-cru-Rework-rzg2l_cru_fill_hw_slot.patch media style ERROR: ./0012-media-rzg2l-cru-Rework-rzg2l_cru_fill_hw_slot.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0013-media-rzg2l-cru-Remove-the-state-variable.patch media style ERROR: ./0013-media-rzg2l-cru-Remove-the-state-variable.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0014-media-rzg2l-cru-Remove-debug-printouts-from-irq.patch media style ERROR: ./0014-media-rzg2l-cru-Remove-debug-printouts-from-irq.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0015-media-rzg2l-cru-Simplify-irq-return-value-handling.patch media style ERROR: ./0015-media-rzg2l-cru-Simplify-irq-return-value-handling.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0016-media-rzv2h-ivc-Wait-for-frame-end-in-stop_streaming.patch media style ERROR: ./0016-media-rzv2h-ivc-Wait-for-frame-end-in-stop_streaming.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0017-media-mali-c55-Remove-unneeded-semicolon.patch media style ERROR: ./0017-media-mali-c55-Remove-unneeded-semicolon.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0018-media-mali-c55-Initialise-dev-for-tpg-rsz-isp-subdev.patch media style ERROR: ./0018-media-mali-c55-Initialise-dev-for-tpg-rsz-isp-subdev.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0019-media-mali-c55-core-Remove-redundant-dev_err.patch media style ERROR: ./0019-media-mali-c55-core-Remove-redundant-dev_err.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0020-media-mali-c55-Fix-possible-ERR_PTR-in-enable_stream.patch media style ERROR: ./0020-media-mali-c55-Fix-possible-ERR_PTR-in-enable_stream.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0021-media-mali-c55-Add-missing-of_reserved_mem_device_re.patch media style ERROR: ./0021-media-mali-c55-Add-missing-of_reserved_mem_device_re.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0022-media-mali-c55-Power-off-the-peripheral-in-remove.patch media style ERROR: ./0022-media-mali-c55-Power-off-the-peripheral-in-remove.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test media-patchstyle:./0023-media-mali-c55-Disable-pm_runtime-on-probe-error.patch media style ERROR: ./0023-media-mali-c55-Disable-pm_runtime-on-probe-error.patch: Missing committer Jacopo Mondi <[email protected]> Signed-off-by # Test checkpatch:./0004-media-rzg2l-cru-Use-proper-guard-in-irq-handler.patch checkpatch CHECK: Avoid CamelCase: <CRUnINTS2> #35: FILE: drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:675: +irq_status = rzg2l_cru_read(cru, CRUnINTS2); CHECK: Avoid CamelCase: <CRUnINTS2_FExS> #67: FILE: drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:690: +if (irq_status & CRUnINTS2_FExS(0) || total: 0 errors, 0 warnings, 2 checks, 122 lines checked # Test checkpatch:./0005-media-rzg2l-cru-Remove-locking-from-start-stop-routi.patch checkpatch CHECK: Avoid CamelCase: <ICnMS> #53: FILE: drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:354: +while ((rzg2l_cru_read(cru, ICnMS) & ICnMS_IA) && retries++ < RZG2L_RETRIES) CHECK: Avoid CamelCase: <ICnMS_IA> #53: FILE: drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:354: +while ((rzg2l_cru_read(cru, ICnMS) & ICnMS_IA) && retries++ < RZG2L_RETRIES) total: 0 errors, 0 warnings, 2 checks, 44 lines checked # Test checkpatch:./0008-media-rz2gl-cru-Introduce-a-spinlock-for-hw-operatio.patch checkpatch CHECK: spinlock_t definition without comment #63: FILE: drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h:163: +spinlock_t hw_lock; total: 0 errors, 0 warnings, 1 checks, 41 lines checked # Test checkpatch:./0011-media-rz2gl-cru-Return-pending-buffers-in-order.patch checkpatch CHECK: Macro argument reuse 'cru' - possible side-effects? #47: FILE: drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:59: +#define for_each_cru_slot_from(cru, slot, start)\ +for ((slot) = rzg2l_cru_slot_next((cru), (start));\ + (slot) != (start); (slot) = rzg2l_cru_slot_next((cru), (slot))) CHECK: Macro argument reuse 'slot' - possible side-effects? #47: FILE: drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:59: +#define for_each_cru_slot_from(cru, slot, start)\ +for ((slot) = rzg2l_cru_slot_next((cru), (start));\ + (slot) != (start); (slot) = rzg2l_cru_slot_next((cru), (slot))) CHECK: Macro argument reuse 'start' - possible side-effects? #47: FILE: drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:59: +#define for_each_cru_slot_from(cru, slot, start)\ +for ((slot) = rzg2l_cru_slot_next((cru), (start));\ + (slot) != (start); (slot) = rzg2l_cru_slot_next((cru), (slot))) CHECK: Avoid CamelCase: <AMnMBS_MBSTS> #110: FILE: drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:617: +cru->active_slot = amnmbs & AMnMBS_MBSTS; total: 0 errors, 0 warnings, 4 checks, 125 lines checked Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded. For more details, check the full report at: https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/99946026/artifacts/report.htm . Best regards, and Happy Hacking! Media CI robot on behalf of the linux-media community. --- Check the latest rules for contributing your patches at: https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html If you believe that the CI is wrong, kindly open an issue at https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all to this message. _______________________________________________ linuxtv-commits mailing list -- [email protected] To unsubscribe send an email to [email protected]
