Dear Laurent Pinchart:
Thanks for your patches! Unfortunately the Media CI robot detected some
issues:
# Test checkpatch:./0006-media-renesas-vsp1-Use-mutex-scoped-guards.patch
checkpatch
CHECK: spaces preferred around that '*' (ctx:VxV)
#253: FILE: drivers/media/platform/renesas/vsp1/vsp1_hgt.c:157:
+lower = hgt->hue_areas[i*2 + 0];
^
CHECK: spaces preferred around that '*' (ctx:VxV)
#254: FILE: drivers/media/platform/renesas/vsp1/vsp1_hgt.c:158:
+upper = hgt->hue_areas[i*2 + 1];
^
total: 0 errors, 0 warnings, 2 checks, 300 lines checked
# Test
checkpatch:./0009-media-renesas-vsp1-Simplify-iteration-over-format-ar.patch
checkpatch
CHECK: Macro argument reuse 'info' - possible side-effects?
#28: FILE: drivers/media/platform/renesas/vsp1/vsp1_pipe.c:232:
+#define vsp1_for_each_format(info, formats) \
+for (const struct vsp1_format_info *info = &formats[0]; \
+ info < formats + ARRAY_SIZE(formats); ++info)
CHECK: Macro argument 'info' may be better as '(info)' to avoid precedence
issues
#28: FILE: drivers/media/platform/renesas/vsp1/vsp1_pipe.c:232:
+#define vsp1_for_each_format(info, formats) \
+for (const struct vsp1_format_info *info = &formats[0]; \
+ info < formats + ARRAY_SIZE(formats); ++info)
CHECK: Macro argument reuse 'formats' - possible side-effects?
#28: FILE: drivers/media/platform/renesas/vsp1/vsp1_pipe.c:232:
+#define vsp1_for_each_format(info, formats) \
+for (const struct vsp1_format_info *info = &formats[0]; \
+ info < formats + ARRAY_SIZE(formats); ++info)
CHECK: Macro argument 'formats' may be better as '(formats)' to avoid
precedence issues
#28: FILE: drivers/media/platform/renesas/vsp1/vsp1_pipe.c:232:
+#define vsp1_for_each_format(info, formats) \
+for (const struct vsp1_format_info *info = &formats[0]; \
+ info < formats + ARRAY_SIZE(formats); ++info)
total: 0 errors, 0 warnings, 4 checks, 83 lines checked
Please fix your series, and upload a new version. If you have a patchwork
account, do not forget to mark the current series as Superseded.
For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/100399088/artifacts/report.htm
.
Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.
---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
to this message.
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
