On Thu Dec 18 10:23:50 2025 +0100, Michael Tretter wrote:
> entity->pads is an array that contains all the pads of an entity.
>
> Calling __media_pipeline_start() or __media_pipeline_stop() on the pads,
> implicitly starts the pipeline with the first pad in this array as origin.
>
> Explicitly use the first pad to start the pipeline to make this more
> obvious to the reader.
>
> Reviewed-by: Frank Li <[email protected]>
> Reviewed-by: Philipp Zabel <[email protected]>
> Signed-off-by: Michael Tretter <[email protected]>
> Signed-off-by: Frank Li <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>
Patch committed.
Thanks,
Hans Verkuil
drivers/staging/media/imx/imx-media-utils.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
---
diff --git a/drivers/staging/media/imx/imx-media-utils.c
b/drivers/staging/media/imx/imx-media-utils.c
index f520529a7cfe..bd9af147a801 100644
--- a/drivers/staging/media/imx/imx-media-utils.c
+++ b/drivers/staging/media/imx/imx-media-utils.c
@@ -754,6 +754,7 @@ int imx_media_pipeline_set_stream(struct imx_media_dev
*imxmd,
bool on)
{
struct v4l2_subdev *sd;
+ struct media_pad *pad;
int ret = 0;
if (!is_media_entity_v4l2_subdev(entity))
@@ -762,17 +763,19 @@ int imx_media_pipeline_set_stream(struct imx_media_dev
*imxmd,
mutex_lock(&imxmd->md.graph_mutex);
+ pad = &entity->pads[0];
+
if (on) {
- ret = __media_pipeline_start(entity->pads, &vdev->pipe);
+ ret = __media_pipeline_start(pad, &vdev->pipe);
if (ret)
goto out;
ret = v4l2_subdev_call(sd, video, s_stream, 1);
if (ret)
- __media_pipeline_stop(entity->pads);
+ __media_pipeline_stop(pad);
} else {
v4l2_subdev_call(sd, video, s_stream, 0);
- if (media_pad_pipeline(entity->pads))
- __media_pipeline_stop(entity->pads);
+ if (media_pad_pipeline(pad))
+ __media_pipeline_stop(pad);
}
out:
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
