On Thu May 7 00:56:49 2026 +0300, Laurent Pinchart wrote:
> This reverts commit 133ac42af0a1b389e8b7b3dc7c1cc8c30ff162b6.
>
> The change to format initialization, along with the change to format
> propagation in the BRx in commit 937f3e6b51f1 ("media: renesas: vsp1:
> brx: Fix format propagation"), broke configuration of the DRM pipeline.
> Revert it to fix the regression.
>
> The original commit was meant to fix a v4l2-compliance failure, with no
> known userspace applications being affected beside test tools. Reverting
> is the simplest option, a more comprehensive fix can be developed (and
> tested more thoroughly) later.
>
> Fixes: 133ac42af0a1 ("media: renesas: vsp1: Initialize format on all pads")
> Tested-by: Lad Prabhakar <[email protected]> # On RZ/T2H
> Reviewed-by: Lad Prabhakar <[email protected]>
> Link:
> https://patch.msgid.link/20260506215650.1897177-2-laurent.pinchart+rene...@ideasonboard.com
> Signed-off-by: Laurent Pinchart <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>
Patch committed.
Thanks,
Hans Verkuil
drivers/media/platform/renesas/vsp1/vsp1_entity.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/drivers/media/platform/renesas/vsp1/vsp1_entity.c
b/drivers/media/platform/renesas/vsp1/vsp1_entity.c
index 1dad9589768c..839b75b62ceb 100644
--- a/drivers/media/platform/renesas/vsp1/vsp1_entity.c
+++ b/drivers/media/platform/renesas/vsp1/vsp1_entity.c
@@ -380,7 +380,7 @@ static int vsp1_entity_init_state(struct v4l2_subdev
*subdev,
unsigned int pad;
/* Initialize all pad formats with default values. */
- for (pad = 0; pad < subdev->entity.num_pads; ++pad) {
+ for (pad = 0; pad < subdev->entity.num_pads - 1; ++pad) {
struct v4l2_subdev_format format = {
.pad = pad,
.which = sd_state ? V4L2_SUBDEV_FORMAT_TRY
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
