On Mon Jul 20 20:31:00 2026 +0200, Richard Leitner wrote:
> The migration to CCI helpers made V4L2_CID_FLASH_DURATION write the
> requested duration directly to OV9282_REG_STROBE_FRAME_SPAN, dropping
> the conversion from microseconds to the register value.
>
> This made flash strobes too long and produced overly bright frames.
> Restore the missing calculation so flash duration is programmed
> correctly again.
>
> Fixes: 273f52f3cbec ("media: i2c: ov9282: Convert to CCI register access
> helpers")
> Cc: Xiaolei Wang <[email protected]>
> Cc: [email protected]
> Signed-off-by: Richard Leitner <[email protected]>
> Signed-off-by: Sakari Ailus <[email protected]>
Patch committed.
Thanks,
Sakari Ailus
drivers/media/i2c/ov9282.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c
index 3ba630ec4f2a..5d301660a87d 100644
--- a/drivers/media/i2c/ov9282.c
+++ b/drivers/media/i2c/ov9282.c
@@ -647,7 +647,8 @@ static int ov9282_set_ctrl(struct v4l2_ctrl *ctrl)
ctrl->val ? OV9282_OUTPUT_ENABLE6_STROBE
: 0, NULL);
break;
case V4L2_CID_FLASH_DURATION:
- ret = cci_write(ov9282->regmap, OV9282_REG_STROBE_FRAME_SPAN,
ctrl->val, NULL);
+ ret = cci_write(ov9282->regmap, OV9282_REG_STROBE_FRAME_SPAN,
+ ov9282_us_to_flash_duration(ov9282, ctrl->val),
NULL);
break;
default:
dev_err(ov9282->dev, "Invalid control %d", ctrl->id);
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
