On Thu Jun 4 05:04:51 2026 +0000, Hungyu Lin wrote:
> Check the return value of pm_runtime_resume_and_get() in
> iris_core_deinit().
> 
> If runtime PM resume fails, skip hardware power-off operations but
> still perform software teardown and state transition. Also skip the
> corresponding pm_runtime_put_sync() call to avoid unbalanced runtime
> PM references.
> 
> Fixes: bb8a95aa038e ("media: iris: implement power management")
> Signed-off-by: Hungyu Lin <[email protected]>
> Signed-off-by: Bryan O'Donoghue <[email protected]>

Patch committed.

Thanks,
Bryan O'Donoghue

 drivers/media/platform/qcom/iris/iris_core.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

---

diff --git a/drivers/media/platform/qcom/iris/iris_core.c 
b/drivers/media/platform/qcom/iris/iris_core.c
index 52bf56e517f9..8c335dbfce16 100644
--- a/drivers/media/platform/qcom/iris/iris_core.c
+++ b/drivers/media/platform/qcom/iris/iris_core.c
@@ -12,18 +12,24 @@
 
 void iris_core_deinit(struct iris_core *core)
 {
-       pm_runtime_resume_and_get(core->dev);
+       int ret;
+
+       ret = pm_runtime_resume_and_get(core->dev);
 
        mutex_lock(&core->lock);
        if (core->state != IRIS_CORE_DEINIT) {
                iris_fw_unload(core);
-               iris_vpu_power_off(core);
+
+               if (!ret)
+                       iris_vpu_power_off(core);
+
                iris_hfi_queues_deinit(core);
                core->state = IRIS_CORE_DEINIT;
        }
        mutex_unlock(&core->lock);
 
-       pm_runtime_put_sync(core->dev);
+       if (!ret)
+               pm_runtime_put_sync(core->dev);
 }
 
 static int iris_wait_for_system_response(struct iris_core *core)
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to