On Tue Sep 15 15:55:20 2026 +0800, Guangshuo Li wrote:
> The error path taken when ar0521_power_on() fails calls
> media_entity_cleanup() at the disable label and then falls through to
> the entity_cleanup label, where media_entity_cleanup() is called again.
>
> There is no need to clean up the media entity twice. Remove the first
> call and let all error paths converge on the common entity_cleanup
> label.
>
> This issue was found by manual code inspection.
>
> Fixes: 852b50aeed15 ("media: On Semi AR0521 sensor driver")
> Signed-off-by: Guangshuo Li <[email protected]>
> Signed-off-by: Sakari Ailus <[email protected]>
Patch committed.
Thanks,
Sakari Ailus
drivers/media/i2c/ar0521.c | 1 -
1 file changed, 1 deletion(-)
---
diff --git a/drivers/media/i2c/ar0521.c b/drivers/media/i2c/ar0521.c
index ed324c2d87aa..be68789eb8f5 100644
--- a/drivers/media/i2c/ar0521.c
+++ b/drivers/media/i2c/ar0521.c
@@ -1142,7 +1142,6 @@ static int ar0521_probe(struct i2c_client *client)
disable:
v4l2_async_unregister_subdev(&sensor->sd);
- media_entity_cleanup(&sensor->sd.entity);
free_ctrls:
v4l2_ctrl_handler_free(&sensor->ctrls.handler);
entity_cleanup:
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
