On Tue Sep 15 17:19:20 2026 +0800, Guangshuo Li wrote:
> t4ka3_probe() marks the device runtime active and enables runtime PM,
> but does not increment the runtime PM usage counter. Nevertheless, the
> probe failure path calls pm_runtime_put_noidle(), which has no matching
> runtime PM get operation.
>
> pm_runtime_put_noidle() currently does not decrement usage_count when
> it is already zero, so the call is ineffective. Remove the unmatched
> put to keep the runtime PM reference handling balanced and avoid
> misleading cleanup code.
>
> This issue was found by manual code inspection.
>
> Fixes: fd55319692151 ("media: Add t4ka3 camera sensor driver")
> Signed-off-by: Guangshuo Li <[email protected]>
> Signed-off-by: Sakari Ailus <[email protected]>
Patch committed.
Thanks,
Sakari Ailus
drivers/media/i2c/t4ka3.c | 1 -
1 file changed, 1 deletion(-)
---
diff --git a/drivers/media/i2c/t4ka3.c b/drivers/media/i2c/t4ka3.c
index a5a68e3fbec2..bf48a56f5a91 100644
--- a/drivers/media/i2c/t4ka3.c
+++ b/drivers/media/i2c/t4ka3.c
@@ -1034,7 +1034,6 @@ err_media_entity:
err_pm_disable:
pm_runtime_disable(&client->dev);
- pm_runtime_put_noidle(&client->dev);
t4ka3_pm_suspend(&client->dev);
return ret;
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
