On Sat Aug 1 12:14:48 2026 +0530, Sachin Kumar Garg wrote:
> iris_set_stage() computes work_mode and sends it to firmware but
> never updates inst->fw_caps[STAGE].value, leaving the cached STAGE
> value stale. iris_vpu_enc_bin_size() and
> iris_vpu3x_vpu4x_calculate_frequency() read this cached value, so a
> stale default causes them to miscalculate buffer size and clock
> frequency for sessions actually running in a different stage than
> the cached one.
>
> Update inst->fw_caps[cap_id].value with the computed work_mode
> before sending it to firmware, keeping the cache consistent with
> what is actually configured.
>
> Fixes: 3a19d7b9e08b ("media: iris: implement set properties to firmware
> during streamon")
> Reviewed-by: Vikash Garodia <[email protected]>
> Signed-off-by: Sachin Kumar Garg <[email protected]>
> Signed-off-by: Bryan O'Donoghue <[email protected]>
Patch committed.
Thanks,
Bryan O'Donoghue
drivers/media/platform/qcom/iris/iris_ctrls.c | 2 ++
1 file changed, 2 insertions(+)
---
diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c
b/drivers/media/platform/qcom/iris/iris_ctrls.c
index cdd02328cb71..14e0bc06e1ad 100644
--- a/drivers/media/platform/qcom/iris/iris_ctrls.c
+++ b/drivers/media/platform/qcom/iris/iris_ctrls.c
@@ -525,6 +525,8 @@ int iris_set_stage(struct iris_inst *inst, enum
platform_inst_fw_cap_type cap_id
work_mode = STAGE_1;
}
+ inst->fw_caps[cap_id].value = work_mode;
+
return hfi_ops->session_set_property(inst, hfi_id,
HFI_HOST_FLAGS_NONE,
iris_get_port_info(inst, cap_id),
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
