This is an automatic generated email to let you know that the following patch were queued at the http://git.linuxtv.org/cgit.cgi/v4l-utils.git tree:
Subject: v4l2-ctl: fix --set/try-fmt-vbi-out ignoring its arguments Author: Hans Verkuil <[email protected]> Date: Sat Aug 22 16:43:38 2026 +0200 vbi_cmd() parses the suboptions of --set-fmt-vbi-out and --try-fmt-vbi-out into raw_fmt_out, but vbi_set() passed raw_fmt as the source to fill_raw_vbi() for the output case. This dates back to commit 56626687 ("v4l2-ctl: add support to try/set raw VBI formats"), where the output block was copied from the capture block without updating the source operand. Commit c8756a2e ("v4l2-ctl: fix set raw/sliced vbi format") corrected the destination operands on these lines, but the source was missed. Since fill_raw_vbi() only copies non-zero fields, --set-fmt-vbi-out on its own was a silent no-op: raw_fmt is all zeroes, so the values returned by VIDIOC_G_FMT were passed back unmodified. When combined with --set-fmt-vbi the output format incorrectly inherited the capture settings. Signed-off-by: Hans Verkuil <[email protected]> Assisted-by: Claude-Code:claude-opus-5 utils/v4l2-ctl/v4l2-ctl-vbi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=b57e72ad562f17b533c513230926ee72a82bc770 diff --git a/utils/v4l2-ctl/v4l2-ctl-vbi.cpp b/utils/v4l2-ctl/v4l2-ctl-vbi.cpp index dc7b4282c72e..3eea0afa099f 100644 --- a/utils/v4l2-ctl/v4l2-ctl-vbi.cpp +++ b/utils/v4l2-ctl/v4l2-ctl-vbi.cpp @@ -227,7 +227,7 @@ void vbi_set(cv4l_fd &_fd) fmt.type = V4L2_BUF_TYPE_VBI_OUTPUT; doioctl(fd, VIDIOC_G_FMT, &fmt); - fill_raw_vbi(fmt.fmt.vbi, raw_fmt.fmt.vbi); + fill_raw_vbi(fmt.fmt.vbi, raw_fmt_out.fmt.vbi); if (options[OptSetVbiOutFormat]) ret = doioctl(fd, VIDIOC_S_FMT, &fmt); else _______________________________________________ linuxtv-commits mailing list -- [email protected] To unsubscribe send an email to [email protected]
