On Tue, Mar 4, 2014 at 5:16 AM, Egbert Eich <e...@freedesktop.org> wrote: > From: Egbert Eich <e...@suse.com> > > Currently the detection of the tool type is somewhat messy: > It is done is in two places: early in usbDispatchEvents() > by calling usbInitToolType() and later on in the same function > when the events are parsed. > usbInitToolType() is used to set (wcmUSBData*)->wcmDeviceType, > the detection that happens later when the events are parsed > sets (WacomDeviceState).device_type. These variables are matched > against each to find the right channel for a device. > If the algorithms used for both set of tool type detection diverge > undesirable effects may happen: it may be impossible to find the > correct channel for a device. > Therefore it is advisable to determine the tool type only once - > ie. in usbInitToolType() - and copy the result to > (WacomDeviceState).device_type if this value is unset. > > Egbert Eich (6): > Remove unused code > Fix initial device type detection > Add missing key codes to toolTypeToDeviceType() > Add missing BTN_TOUCH key code to toolTypeToDeviceType() > Remove duplicate tool type detection > Attempt to derive the tool type from a kown button/key event > > src/wcmUSB.c | 117 > ++++++++++++++++++++++++++++++++--------------------------- > 1 file changed, 64 insertions(+), 53 deletions(-) > > -- > 1.8.4.5 >
Can this patchset wait until the next release? The device type code is pretty subtle, and though I _think_ you've managed to get it mostly right (there is one definite problem later on that needs to be addressed), I'd like to make sure it's gets thorough testing. I was planning on making an RC release in the next few days and then a final release next week. Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take seven from three, / So you look at the sixty-fours.... ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
