On Tue, Mar 11, 2014 at 12:31 PM, Egbert Eich <e...@freedesktop.org> wrote: > From: Egbert Eich <e...@suse.com> > > This is the second version of my patch set to clean up and unify > device type detection. > I've incorporated all suggestions by Jason. > Patch (2) and (4) are new. Patch (5) is a combination of 3 separate > patches from my previous set. > > Jason suggested to wait with the inclusion of this set until after > the release. I'm fine with that. > > Egbert Eich (6): > (1) Remove unused code > (2) Zero is not a valid device ID, don't derive a type from it > (3) Fix initial device type detection > (4) Store the last used channel rather than blindly taking channel 0 > (5) Remove duplicate tool type detection > (6) Attempt to derive the tool type from a kown button/key event > > src/wcmUSB.c | 135 > ++++++++++++++++++++++++++++++++++------------------------- > 1 file changed, 79 insertions(+), 56 deletions(-) > > -- > 1.8.4.5 >
Finally getting back to this. There are a few final nitpicks I've mentioned in the retrospective patches, and a v3 should be sent with them fixed and rebased onto master. I'll merge them once they show up :) For the set (inline comments notwithstanding) Reviewed-by: Jason Gerecke <killert...@gmail.com> Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take seven from three, / So you look at the sixty-fours.... ------------------------------------------------------------------------------ Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
