On Tue, Nov 24, 2009 at 08:56:51PM -0800, Ping wrote: > > In addition, the comment style changes between the files. > > I'm not adverse to having proper doxygen comments instead, but I'm also not > > adverse to simply remove comments like (fake example): > > /* xf86WcmAddTwoNumbers - adds two numbers */ > > > > xf86-input-wacom is in your $HOME. Feel free to change it to whatever > format/style you like. I don't have an attachment to the existing style. > If you have a preferred style for xf86-input-wacom, please share with us. I > am willing to go with any style as long as we get the job done. As for the > "good habit" part, it takes time to adapt, especially for the "old dogs" > like me. > > Fair?
sure, but please consider (and I want this publicly stated here :) that it's in my $HOME because that was easily available when we forked it. once the big cleanup is done, it'll likely move to a more permanent place. in terms of style: I try to use whatever style is used in the surrounding code or the same file. I'm not a big fan of /*********/ comments, especially if they don't convey information (writing good comments is hard, surprisingly so). removing those won't affect the code, so I might just do that in a spare and bored minute. in terms of style, that's the only thing I'd drop though, the rest doesn't really matter enough to really worry about it. in terms of changing contributions: sometimes I change them in minor matters (e.g. indentation or commit messages), but not the code itself. I have found though that asking a developer to resubmit a patch with minor changes is better than fixing it up myself - simply because it scales better. I think it's a fair assumption that someone who's willing to write a patch is also ok with fixing up a few tabs and spaces. Cheers, Peter ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
