Dnia 2009-11-22, nie o godzinie 14:05 -0800, Ping pisze: > However, this is an open source project. You can provide a guideline > for us or share your suggestions with us. We are more than happy to > accept any contributions to the project, especially for > xf86-input-wacom, which bears our future. We want, by all means, to > make it easier for others to contribue to linuxwacom project.
OK, here is first sketch of proposed changes in the structure of the driver: wcmCommon.c - contains all funcions required for handling a tablet (receiving, handling, sending events), but not for initializing/opening/closing/configuring tablet or manipulating data). xf86WcmOpen should be in xf86Wacom.c wcmCompat.c - DELETE. xf86WcmWait to be moved to wcmISDV4.c (it's used only there) xf86WcmReady be moved to wcmWacom.c (it's used only there) wcmConfig.c - allocating device, initialising, plugging, unplugging, uninitialising. xf86WcmPointInArea, xf86WcmAreasOverlap, xf86WcmAreaListOverlap should be moved to wcmCommon wcmFilter.c - data filtering (like pressure curve functions or jitter correction, tilt2rotation) wcmFilter.h - header file for wcmFilter.c wcmISDV4.c - Wacom IV protocol specific functions wcmTilt2Rotation.c - DELETE. Function xf86WcmTilt2R to be moved to wcmFilter, tiltTable to go to wcmFilter.h wcmUSB.c - USB specific functions. WacomModel definitions to be moved to a new wcmUSB.h header file. Another option is to create wcmConfig.h and drop all USB and ISDV4 definitions there. wcmValidateDevice.c - probing, parsing, checking for duplicate device wcmXCommand.c - Mode switching and screen changing functions, xf86WcmSetProperty and InitWcmDeviceProperties to be moved to xf86Config.c xf86Wacom.c - opening, closing device, change control. Option 2: merge xf86Wacom with wcmConfig. xf86WcmRegisterX11Devices to be moved to wcmConfig.c and xf86WcmIsWacomDevice to wcmValidateDevice.c My goal is to create a logical structure, easy to understand by a newcomer. A next thing is that if you, lets say, want to check some USB functions you don't need to see all the properties of all USB tablets (even nicely folded by vim), that's why I added a separate header file with the definitions. I'm sure it can be done better, so I'm open to all suggestions. -- regards, Przemo ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
