Przemo, Without initializing the max/min to the real values, your priv->maxWidth and priv->maxHeight can be wrong in a few odd settings since you assumed that min would never be larger than 0 and max would never be smaller than 0.
Here are two examples to explain what I mean: 1. one screen with (24x24, 1024x1024). With your patch, we get: priv->maxWidth = maxX = 1024 and priv->maxHeight = maxY = 1024. The actual priv->maxWidth and priv->maxHeight should both be 1000. Yeah, not a big deal. But, they are both wrong :). 2. one screen with (-102x-1024, -24x-24). I am pretty sure you know what I mean. You've made a very nice try. Keep up the great work! Ping 2009/12/18 Przemysław Firszt <[email protected]> > Hi, > Patch strips redundant code from xf86WcmDesktopSize function as > there is no need for special handling of one screen case if we can do it > in the same loop as for multi screen. > > -- > Przemo >
------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
