Dnia 2009-12-23, śro o godzinie 10:40 -0800, Ping pisze: Ping, > With this speed, looks like you are going to walk your way through the > guidelines during the holiday break :). Before you dig further, I'd > like to clarify my ideas on a few items in your original proposal. > Let me know if you have a different view. I'm just trying to keep you and Peter busy :-) [..] > > wcmConfig.c - allocating device, initialising, plugging, unplugging, > > uninitialising. xf86WcmPointInArea, xf86WcmAreasOverlap, > > xf86WcmAreaListOverlap should be moved to wcmCommon > > If you looked at linuxwacom code, you might have noticed a file, > wcmMapping.c, there, which is not in xf86-input-wacom. I am planning > to do the same change for xf86-input-wacom ( I just don't have the > time to work on it). I may add 2 new files, wcmTabletMapping.c and > wcmDispalyMapping, to leave more room for mapping to grow. From my > experience, mapping itself is a big feature that needs quite a lot of > efforts. > > So, please hold on your intention to move around the > tablet/screen/display mapping related stuff. Once I have the files in > place, it would be much easier for you to join in. OK, I've got a couple other ideas to keep me occupied :-) > > wcmFilter.c - data filtering (like pressure curve functions or jitter > > correction, tilt2rotation) > > I prefer to keep tilt2rotation as is since it is not a filter. It > converts tilts to rotation, which doesn't filter any data. OK, but I've a related question about the big hardcoded lump of numbers. I'll send it in a separete email. > > > > wcmFilter.h - header file for wcmFilter.c > > > > wcmISDV4.c - Wacom IV protocol specific functions > > > > wcmTilt2Rotation.c - DELETE. Function xf86WcmTilt2R to be moved to > > wcmFilter, tiltTable to go to wcmFilter.h > > Same comments as above. Let me know if you have a different opinion. > I am always open for suggestions. > > > > wcmUSB.c - USB specific functions. WacomModel definitions to be > > moved to > > a new wcmUSB.h header file. Another option is to create wcmConfig.h > > and > > drop all USB and ISDV4 definitions there. > > > I like the second option - share common defines in one header. OK > > > wcmValidateDevice.c - probing, parsing, checking for duplicate device > > > > wcmXCommand.c - Mode switching and screen changing functions, > > xf86WcmSetProperty and InitWcmDeviceProperties to be moved to > > xf86Config.c > > > As Peter suggested, maybe we can move them to xf86Wacom.c? However, I > don't think it is unreasonable even if we leave them in > wcmProperties.c. They are Properties anyway. > > xf86Wacom.c - opening, closing device, change control. Option 2: merge > > xf86Wacom with wcmConfig. xf86WcmRegisterX11Devices to be moved to > > wcmConfig.c and xf86WcmIsWacomDevice to wcmValidateDevice.c > > I'd like to see xf86Wacom.c stay around for the sake of history. I > know that means I am getting old :). So let's leave these 2 files where they are now (for a while, at least ;-) ) -- Przemo
------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
