Ping convinced me not to do it this way since it was using a feature
intended to support button presses to do the opposite and stop button
presses.  I will soon submit a man page update that basically says for
Bamboo P&T that Capacity option *should* equal -1 as its not usable for
P&T.  Thus officially documenting intended behaviour.

I coordinated with Jason yesterday and he is going to give it a first go at
reworking other code so that initial touchon P&T doesn't push button but
that double tap within time window does.

Chris

On Tue, Jan 12, 2010 at 1:26 AM, Peter Hutterer <[email protected]>wrote:

> On Sun, Jan 10, 2010 at 09:09:37PM -0600, Chris Bagwell wrote:
> > Ported Jason Childs linuxwacom patch to xf86-input-wacom.
> > Bamboo P & T's have capacitive touch and should be defaulting
> > to 3.  This change stops unwanted button click when touching
> > pad.
>
> sorry, I lost track of this. Is this patch ready to go in or are we waiting
> for something else?
>
> Ping - a Tested-by or Reviewed-by always helps as a marker so I don't miss
> patches from the list.
>
> Cheers,
>   Peter
>
> > Signed-off-by: Chris Bagwell <[email protected]>
> > ---
> >  src/wcmValidateDevice.c |   10 ++++++++++
> >  1 files changed, 10 insertions(+), 0 deletions(-)
> >
> > diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c
> > index 8a47659..a4fa21f 100644
> > --- a/src/wcmValidateDevice.c
> > +++ b/src/wcmValidateDevice.c
> > @@ -633,6 +633,16 @@ int wcmParseOptions(LocalDevicePtr local, unsigned
> > long* keys)
> >                 common->wcmGestureDefault = 1;
> >         }
> >
> > +       /* Bamboo P&T Capacity defaults to 3 */
> > +       if ((common->tablet_id >= 0xd0) && (common->tablet_id <= 0xd3))
> > +       {
> > +
> > +               /* Capacity is off for all devices except on
> > +                * Bamboo Pen & Touch devices
> > +                */
> > +               common->wcmCapacityDefault = 3;
> > +       }
> > +
> >         /* check if touch was turned off in xorg.conf */
> >         common->wcmTouch = xf86SetBoolOption(local->options, "Touch",
> >                 common->wcmTouchDefault);
> > --
> > 1.6.5.2
>
>
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Linuxwacom-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to