On Thu, Jan 14, 2010 at 6:45 PM, Chris Bagwell <ch...@cnpbagwell.com> wrote: > > > On Thu, Jan 14, 2010 at 7:33 PM, Ping <pingli...@gmail.com> wrote: >> >> > + /* If Mode not specified or is invalid then rely on >> > + * Type specific defaults from initialization. >> > + * >> > + * If Mode default is hardware specific then handle here: >> > + * >> > + * touch Types are initialized to Absolute. >> > + * Bamboo P&T touch pads need to change default to Relative. >> > */ >> > - if (IsCursor(priv)) >> > + if (IsTouch(priv) && >> > + (common->tablet_id >= 0xd0) && (common->tablet_id <= 0xd3)) >> >> We don't want to break cursor set up, do we :)? >> >> if (IsCursor(priv) || (IsTouch(priv) && >> (common->tablet_id >= 0xd0) && (common->tablet_id <= 0xd3))) >> > > I purposely removed code for all cases but "touch". All Absolute vs. > Relative settings are set to correct defaults in xf86WcmAllocateByType() > except for Bamboo P&T "touch" case and special case of "pad" while in Core > mode. Core case is already correctly overridden in logic right below where > this patch applies. That leaves new code in patch to address "touch" case.
I see your point after reading the patch again. > The old code was both duplicate logic with and easy to get out of sync with > xf86WcmAllocateByType(); although at least it was previously only executed > in syntax error of Mode value case. > > Appreciate your time reviewing... It is my pleasure. Ping ------------------------------------------------------------------------------ Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
