Reviewed-by: Ping Cheng <[email protected]> For both patches attached to this thread.
Ping 2010/2/2 Przemysław Firszt <[email protected]> > > Dnia 2010-02-01, pon o godzinie 14:33 -0800, Ping Cheng pisze: > > 2010/1/29 Przemysław Firszt <[email protected]> > > Hi, > > It's the last part of "rename xf86Wcm* to wcm*" story. > > There are a few more remaining, but only in xf86Msg calls: > > > > src/wcmCommon.c:xf86Msg(X_ERROR, "Wacom xf86WcmWrite error : % > > s\n", > > strerror(errno)); > > > > src/wcmISDV4.c: xf86Msg(X_WARNING, "%s: xf86WcmWrite > > ISDV4_STOP error : > > %s\n", > > > > src/wcmISDV4.c: xf86Msg(X_WARNING, "%s: unable to xf86WcmWrite > > request % > > s " > > > > src/wcmISDV4.c: xf86Msg(X_ERROR, "%s: xf86WcmWrite error : %s > > \n", > > local->name, strerror(errno)); > > > > src/wcmISDV4.c: xf86Msg(X_ERROR, "Wacom xf86WcmRead error : %s > > \n", > > > > src/xf86Wacom.h: * xf86WcmRead() returns -1 AND errno is left > > as EINTR > > from hell knows where. > > > > I'm not fixing them now, because I'm not sure "what author > > wants to say" > > > > I'd say we change them all in the same patch or leave them all as is > > to avoid future confusion. I vote for changing them all. > I'm afraid I didn't express myself clearly enough - sorry for this. > We dont have xf86Wcm{Read,Write}, xf86{Read,Write} or wcm{Read,Write} > functions in the code. > [2 minutes for googling] > I found this: > #define xf86WcmRead(a,b,c) xf86ReadSerial((a),(b),(c)) > #define xf86WcmWrite(a,b,c) xf86WriteSerial((a),(char*)(b),(c)) > ,so I'll rename xf86WcmRead/Write to xf86{Read,Write}Serial - see > attached patch. > -- > Przemo > > ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
