On Thu, Mar 18, 2010 at 12:32 AM, Peter Hutterer
<peter.hutte...@who-t.net> wrote:
> Please give this a quick spin, if it works for you I'd like to merge it and
> push out 0.10.5 - it's long overdue. If it breaks something, I'll probably
> push out 0.10.5 without it and let this simmer for longer.

Peter, before you release 0.10.5, I'd really like to get a Bamboo
specific work around in.  Linuxwacom has already deleted the logic in
question but it can't be totally deleted in xf86-input-wacom until a
large patch related to gestures is brought over.

I'll send a patch in tonight but in case your working fast, here is
the code in question.

In wcmUSB.c - wcmParseChannel() - Line 999 - This logic is meant to
only execute on touch screens.  It doesn't make sense to execute on
touch pads and is source of common complaint that Bamboo users are
getting unwanted mouse clicks:

                                if (common->wcmCapacityDefault < 0)
                                        MOD_BUTTONS (0, event->value);

I wrapped it with following for time being (from my MT patch though):

                        /* FIXME: This conflicts with gesture logic
                         * in wcmEvent().  It should be centralized
                         * there.  Also, touchpads should not be
                         * calling this.   We do not have the
                         * correct priv pointer handy to check
                         * for ABSOLUTE mode so doing it the easy
                         * way until gesture logic is centralized.
                         */
                        if (!(common->tablet_id >= 0xd0 &&
common->tablet_id <= 0xd3))

Chris

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to