On Thu, Mar 18, 2010 at 09:40:09AM -0700, Ping Cheng wrote: > Reviewed-by: Ping Cheng <[email protected]> > > -------------------------------------------- > Peter, > > I think you copied the ClickForce option code for threshold somehow > since ClickForce ranges from 1 to 21. ClickForce was an option for > wacomcpl to display the threshold in integer (scroll bar scales).
Ah, that would explain it. Thanks. I've amended the commit message accordingly. Cheers, Peter > On Thu, Mar 18, 2010 at 12:13 AM, Peter Hutterer > <[email protected]> wrote: > > Not sure where the 21 came from, maybe some old code that I copied when > > doing the property work. Either way, my tablet alreay starts with 245 as > > threshold, so a limit of 21 seems a tad low. The default is maxZ * 3/50. > > > > Signed-off-by: Peter Hutterer <[email protected]> > > --- > > src/wcmXCommand.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c > > index 0fd2ca0..3f250da 100644 > > --- a/src/wcmXCommand.c > > +++ b/src/wcmXCommand.c > > @@ -510,7 +510,7 @@ int wcmSetProperty(DeviceIntPtr dev, Atom property, > > XIPropertyValuePtr prop, > > > > value = *(CARD32*)prop->data; > > > > - if ((value < 1) || (value > 21)) > > + if ((value < 1) || (value > common->wcmMaxZ)) > > return BadValue; > > > > if (!checkonly) > > -- > > 1.6.6.1 ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
