I don't remember the exact cause. But I do remember that memset didn't reset the bits somehow. It could be on an older Linux systems since my testing was mainly on legacy systems, you know.
If your testing works on Xorg 1.7 and later, we can apply the patch for xf86-input-wacom and keep linuxwacom as is. Ping On Sun, Mar 21, 2010 at 10:58 PM, Peter Hutterer <[email protected]> wrote: > Signed-off-by: Peter Hutterer <[email protected]> > --- > If the comment is correct, then it would be a bug in libc. Which would need > to be investigated but for now I'm giving it the benefit of the doubt and > claim that memset works equally well. > > Ping, can you remember why it didn't work? > > src/wcmISDV4.c | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/src/wcmISDV4.c b/src/wcmISDV4.c > index eeb348e..1cfb8f3 100644 > --- a/src/wcmISDV4.c > +++ b/src/wcmISDV4.c > @@ -683,7 +683,7 @@ static int wcmWaitForTablet(LocalDevicePtr local, char* > answer, int size) > */ > int isdv4ProbeKeys(LocalDevicePtr local) > { > - int id, i; > + int id; > int tablet_id = 0; > struct serial_struct tmp; > const char *device = xf86SetStrOption(local->options, "Device", NULL); > @@ -715,9 +715,7 @@ int isdv4ProbeKeys(LocalDevicePtr local) > } > } > > - /* we have tried memset. it doesn't work */ > - for (i=0; i<NBITS(KEY_MAX); i++) > - common->wcmKeys[i] = 0; > + memset(common->wcmKeys, 0, sizeof(common->wcmKeys)); > > /* default to penabled */ > common->wcmKeys[LONG(BTN_TOOL_PEN)] |= BIT(BTN_TOOL_PEN); > -- > 1.6.6.1 > eter > > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Linuxwacom-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel > ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
