Can you change patch title to include phrase "unimplemented" or add note somwhere its unimplemented in driver so its more obvious reason for patch is to align tool and driver and remaining description is why current driver behavior is preferred?
Reviewed-by: Chris Bagwell <[email protected]> Chris On Thu, May 27, 2010 at 11:51 PM, Peter Hutterer <[email protected]>wrote: > NumScreens in linuxwacom returns screenInfo.numScreens - the same value as > reported by ScreenCount(3). If this is 1 and TwinView is enabled, this > value > is hardcoded to 2. > > This logic can be replicated in the client, there's no need to export this > from xsetwacom (or the driver for that matter). > > Note - this logic is incorrect if RandR 1.2 drives multiple screens. > Although there are two physical screens, there is only one protocol screen. > And what happens if you have TwinView and RandR at the same time (multiple > graphics cards) is probably anyone's guess. > > Signed-off-by: Peter Hutterer <[email protected]> > --- > tools/xsetwacom.c | 6 ------ > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c > index 874f42f..38d2cb3 100644 > --- a/tools/xsetwacom.c > +++ b/tools/xsetwacom.c > @@ -830,12 +830,6 @@ static param_t parameters[] = > .prop_flags = PROP_FLAG_READONLY > }, > { > - .name = "NumScreen", > - .desc = "Returns number of screens configured for the > desktop. ", > - .set_func = not_implemented, > - .get_func = not_implemented, > - }, > - { > .name = "XScaling", > .desc = "Returns the status of XSCALING is set or not. ", > .set_func = not_implemented, > -- > 1.6.5.2 > > > ------------------------------------------------------------------------------ > > _______________________________________________ > Linuxwacom-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel >
------------------------------------------------------------------------------
_______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
