On Sun, Aug 22, 2010 at 4:17 PM, Peter Hutterer
<[email protected]> wrote:
> On Fri, Aug 20, 2010 at 01:14:22PM +0100, Przemo Firszt wrote:
>> Dnia 2010-08-19, czw o godzinie 15:57 +1000, Peter Hutterer pisze:
>> > I don't actually know what this is really supposed to do in the end, the
>> > driver does the same thing irrespective of whether leftof or rightof is
>> > specified.
>> >
>> > Signed-off-by: Peter Hutterer <[email protected]>
>> > ---
>> >  tools/xsetwacom.c |   14 ++++++++++++--
>> >  1 files changed, 12 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
>> > index 839be3a..6e5174f 100644
>> > --- a/tools/xsetwacom.c
>> > +++ b/tools/xsetwacom.c
>> > @@ -1,5 +1,5 @@
>> >  /*
>> > - * Copyright 2009 Red Hat, Inc.
>> > + * Copyright 2009 - 2010 Red Hat, Inc.
>> >   *
>> >   * This program is free software; you can redistribute it and/or
>> >   * modify it under the terms of the GNU General Public License
>> > @@ -1889,6 +1889,14 @@ static void set_twinview(Display *dpy, XDevice 
>> > *dev, param_t* param, int argc, c
>> >             twinview = TV_LEFT_RIGHT;
>> >     else if (strcasecmp(argv[0], "vertical") == 0)
>> >             twinview = TV_ABOVE_BELOW;
>> > +   else if (strcasecmp(argv[0], "belowof") == 0)
>> > +           twinview = TV_ABOVE_BELOW;
>> > +   else if (strcasecmp(argv[0], "aboveof") == 0)
>> > +           twinview = TV_BELOW_ABOVE;
>> > +   else if (strcasecmp(argv[0], "rightof") == 0)
>> > +           twinview = TV_LEFT_RIGHT;
>> > +   else if (strcasecmp(argv[0], "leftof") == 0)
>> > +           twinview = TV_RIGHT_LEFT;
>> >     else
>> >             goto error;
>> >
>> > @@ -1918,7 +1926,9 @@ static void set_twinview(Display *dpy, XDevice *dev, 
>> > param_t* param, int argc, c
>> >     return;
>> >
>> >  error:
>> > -   fprintf(stderr, "Usage: xsetwacom <device name> TwinView [none | 
>> > horizontal | vertical]\n");
>> > +   fprintf(stderr, "Usage: xsetwacom <device name> TwinView [<value>]\n");
>> > +   fprintf(stderr, "Values: none, horizontal, vertical, belowof,"
>> > +                   "aboveof, leftof, rightof\n");
>> >     return;
>> >  }
>> >
>> TV_LEFT_RIGHT/TV_RIGHT_LEFT are handled in the same way. Only difference
>> is that priv->currentScreen is set to 0 or 1 (see
>> wcmCommon.c/wcmSetScreen function), but no idea what are further
>> implications of that...

Przemo is right. The difference lies in which one is the primary
monitor, the left one or the right one. The primary monitor has a
screen number 0.

> well, that's the funny thing. I tried with both settings on a left/right and
> on a right/left setup and didn't notice any difference.

Did you set the screen_no option? I guess you didn't. If you don't set
screen_no, you can move the cursor to the other screen by reaching the
edge of the screen. That would not make much difference between leftof
or rightof.

However, if you want the cursor to stay within one screen (no jump
from one to the other), you'll need the screen_no option, which needs
to know if your setting is leftof or rightof. I stated this detail in
the HOWTO (http://linuxwacom.sourceforge.net/index.php/howto/multimonitor).
But even myself get confused from time to time. So, I am not surprised
to know that it has confused another one :).

> So it might just be
> that the _initial_ screen is different? Though that'd be a rather pointless
> distinction then because you can still move between the two screens by
> hitting the connecting edge. The latter behaviour may be new since server
> 1.4 or 1.5 so maybe this used to work differently on older servers.
>
> I generally try to pretend the world didn't exist before 1.4, it's less
> painful that way :)

Well, I didn't test it on X servers 1.7 and later. So, I pretend the
world works the same way as it used to be ....

>> Acked-by: Przemo Firszt <[email protected]>

Acked-by: Ping Cheng <[email protected]>

Ping

------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
_______________________________________________
Linuxwacom-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to