On Wed, Aug 25, 2010 at 4:12 PM, Mike Auty <[email protected]> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 25/08/10 10:45, Ping Cheng wrote: >> >> It must be an issue in the kernel driver. Maybe the signed cast is >> wrong. I'll review your patch once you have it ready. >> > > Found it, although it wasn't quite where I expected it. Apparently my > Graphire 3 doesn't talk either WACOM_G4 or WACOM_MO, and so it was the > change of cast from -(signed char)data[6] to -(signed)data[6] that > caused the problems (presumably signed -1 is stored as unsigned 0xff, so > negating that and putting it into an int would be -255, which is what I > was seeing). I don't know whether the value for WACOM_G4 should be > (signed char) as well, but I suspect that because all the values are > masked off by 0x03 or 0x04, it shouldn't cause a problem.
Since the (signed) is unnecessary for WACOM_G4, I'd like to remove it in your patch as well. > So I've attached the patch. I'm not sure how the patching process > works, will this make it into 2.6.35.4 as well as 2.6.36, or will it > only get pulled for 2.6.36? Since it is a simple fix, I guess it will be backported. Please make a formal patch with your reasoning and testing result in the commit comments. Email the patch to the kernel-input mailing list; cc: Dmitry and me. If you'd like me to take a look at your final patch before submitting, please put "Reviewed-by: Ping Cheng <[email protected]>" under your Signed-off-by tag. Thank you, Mike. Ping P.S., I will update the linuxwacom package accordingly. ------------------------------------------------------------------------------ Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
