On Mon, Aug 30, 2010 at 06:13:07PM +0100, Przemo Firszt wrote:
> Dnia 2010-08-30, pon o godzinie 10:50 +1000, Peter Hutterer pisze:
> > On Fri, Aug 27, 2010 at 03:29:56PM +0100, Przemo Firszt wrote:
> > > Dnia 2010-08-27, pią o godzinie 13:47 +1000, Peter Hutterer pisze:
> > > > A CARD32 is unsigned and cannot be less than 0. Remove the checks and
> > > > move
> > > > the one leftover check down to the switch statement.
> > > > ---
> > > > src/wcmXCommand.c | 7 ++-----
> > > > 1 files changed, 2 insertions(+), 5 deletions(-)
> > > >
> > > > diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c
> > > > index 9e1b5fa..40afe60 100644
> > > > --- a/src/wcmXCommand.c
> > > > +++ b/src/wcmXCommand.c
> > > > @@ -842,13 +842,10 @@ int wcmSetProperty(DeviceIntPtr dev, Atom
> > > > property, XIPropertyValuePtr prop,
> > > > values = (CARD32*)prop->data;
> > > >
> > > > /* non-TwinView settings can not set TwinView
> > > > RESOLUTION */
> > > > - if ((priv->twinview == TV_NONE) || (values[0] < 0) ||
> > > > - (values[1] < 0) || (values[2] < 0) ||
> > > > (values[3] < 0))
> > > > - return BadValue;
> > > > -
> > > > switch(priv->twinview)
> > > > {
> > > > - case TV_NONE: break;
> > > > + case TV_NONE:
> > > > + return BadValue;
> > > > case TV_ABOVE_BELOW:
> > > > case TV_BELOW_ABOVE:
> > > > if ((values[1] + values[3]) !=
> > > > screenInfo.screens[0]->height)
> > > Hi Peter,
> > > xsetwacom --get "WACOM Pen Tablet stylus" TwinView none still works, but
> >
> > "set" or "get"?
> "set", my fault.
please double-check that the xsetwacom you're calling is the new one that
has the parameter removed (and not a system-installed one). git grep doesn't
show any reference to TwinView in xsetwacom anymore.
clients are free to create properties on input devices as they see fit, so
if you run an old xsetwacom against the new driver, it may result in the
property being created though nothing actually listens for it.
Cheers,
Peter
------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
_______________________________________________
Linuxwacom-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
