On Thu, Sep 23, 2010 at 10:36 AM, Chris Bagwell <ch...@cnpbagwell.com> wrote: > > On Sep 22, 2010, at 1:18 PM, Ping Cheng <pingli...@gmail.com> wrote: >>> /* ignore events without information */ >>> - if ((private->wcmEventCnt <= 2) && private->wcmLastToolSerial) >>> + if ((private->wcmEventCnt < 2) && private->wcmLastToolSerial) >> >> Does this change make a difference to your Bamboo tablet, with both >> your new kernel driver and the old linuxwacom kernel driver? I have to >> consider backward compatibility seriously since it is my job. > > Yes for both cases. You can easily see in x logs that it's discarding valid > data. It's mostly only a concern with low volume events like button > presses. So that means newer kernel drivers.
I see. Looks like we need to go with this patch, even for V5 devices, since they have buttons too. >> This code was mainly for protocol 5 devices to deal with a few special >> cases, such as both stylus and pad (tablet buttons) are in use; or >> moving the tablet while touching the tablet buttons. Somehow we get >> invalid data. > > I'll look at protocol 5 kernel drivers and see if I can think of a reason > that invalid data could happen. Worst case, we can make that check specific > to protocol 5 devices. My concern is not just for this particular change. It is for the whole set which may affect both V5 and the existing tablet PC kernel (_TAP_s) support. Since you don't have a V5 device and I don't want to hold this patchset for too long, I am willing to put my Acked-by: tag if you can confirm that your bamboo pen&touch works the same way as it was without your patchset applied, assuming you use the kernel driver from linuxwacom-0.8.8-8 instead of from the input-next repo, which is based on the new MT. Let me know if what I said confuses you more. Thank you so much for your effort. Ping ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
