On Mon, Oct 18, 2010 at 11:36 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Mon, Oct 18, 2010 at 07:53:00PM -0700, Ping Cheng wrote: >> On Sun, Oct 17, 2010 at 7:38 PM, <ch...@cnpbagwell.com> wrote: >> > From: Chris Bagwell <ch...@cnpbagwell.com> >> > >> > usbParseEvent() is for queue'ing up events until a full sync >> > window occurs. It was also selecting a channel related >> > to all queued events. >> > >> > Move channel selection logic to function that processes all events >> > (wcmParseChannel()) since its more related to that logic then >> >> Change "then" to "than", to prove that I have really read the patch :). >> >> > to queuing logic. >> > >> > Also, rename to wcmParseEvents() since some WCM_PROTOCOL_GENERIC >> >> Can we rename it to usbDispatchEvents (usbParseEvents is what you used >> :)? With usbParseEvents and usbParseEvent, one of them sounds like an >> typo. >> >> I have no problem with the code chnage. > > I agree with Ping, please rename it to usbDispatchEvents(), but otherwise. > > Acked-by: Peter Hutterer <peter.hutte...@who-t.net> > > Cheers, > Peter >
Thanks for review all. I will make suggested update and resubmit. I'll wait though for Ping's final comments on patch #3 and patch #5 though to be safe. Chris ------------------------------------------------------------------------------ Download new Adobe(R) Flash(R) Builder(TM) 4 The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly Flex(R) Builder(TM)) enable the development of rich applications that run across multiple browsers and platforms. Download your free trials today! http://p.sf.net/sfu/adobe-dev2dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
