On Wed, Oct 20, 2010 at 3:35 PM, Ping Cheng <pingli...@gmail.com> wrote: > On Wed, Oct 20, 2010 at 12:59 PM, Chris Bagwell <ch...@cnpbagwell.com> wrote: >> On Wed, Oct 20, 2010 at 11:51 AM, Ping Cheng <pingli...@gmail.com> wrote: >>> On Mon, Oct 18, 2010 at 8:24 PM, <ch...@cnpbagwell.com> wrote: >>>> From: Chris Bagwell <ch...@cnpbagwell.com> >>>> >>>> I would apreciate if people could test these patches in real >>>> drawing applications and see if they notice any negative affects. >>>> Also, I'd appreciate any review comments over them. >>> >>> Patches 3 and 4 make sense to me. I have a question for patch 1 >>> though. When you say: >>> >>> "2) wcmCheckSuppress() is called at all times. There used to be 1 >>> very small window were it was skipped on initial startup but I can't >>> see any harm in calling it always." >>> >>> do you mean wcmCheckSuppress is called even for the first in-prox >>> event? I don't think we want to do that since the pLast could, and >>> most likely, be an invalid data at that time. >>> >> >> Your right. Let me think about how best to handle this and I'll add >> it to a future patch. > > We want to handle it now while we are here, don't we? > >> I didn't want to expose pChannel->rawFilter.npoints to wcmCommon like >> it was before to keep things opaque. > > No, you don't need to. > >> Until resolved, the worst case is somewhat randomly the 1st packet >> coming in proximity will not be posted to X. > > This worst case is what I'd like to avoid. One way I think we can deal > with it is to check pLast->proximity. > > If it was out-prox, i.e., we are receiving the first event, we don't > send the event or we send the event without calling wcmCheckSuppress. > In theory, I prefer "sending the event without calling > wcmCheckSuppress". But, only testing on both cases can tell us which > one works better in reality. > > If it is in-prox, process it as usual. > > What do you think?
Sounds good. I'll go off and implement this and then submit this #1 patch for immediate inclusion since its basically a refactoring only once I address the above issue. I'll have the other patches ready as well but hopefully we can get some testing feedback before submission. Chris ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
