On Mon, Nov 15, 2010 at 7:19 AM, Chris Bagwell <ch...@cnpbagwell.com> wrote: > I'd really prefer to solve these issues within the confines of events sent > by what I'm calling "generic" touchpads, touchscreens, and pen tablets. As > an example, I plan to use my synaptics touchpad with MT events to test out > xf86-input-wacom's Bamboo touchpad logic. :-)
Sounds like we are trying to cover all input devices with one driver. Hope we have enough "manpower" here ;). > Its getting hard to keep our heads around all the combination of possible > events for different kinds of devices. Perhaps I should break > usbParseKeyEvent() into two functions? > > usbParseGenericKeyEvent() - set up channel for generic touchpads, > touchscreens, and tablets. > usbParseProtocol45KeyEvent() - set up channel for pre-existing wacom > tablets, touchscreens and touchpads (although touchscreens and tablets look > the same in this case). > > There will be a small bit of code duplication but we can get rid of all > those if/else logic. I don't worry about this. I guess I should not worry about your comment change either. My concern was about the pad tool. My testing result told me that somehow only two of the four Bamboo buttons work with the new driver. Since I don't have time to look into the code, I can not submit a patch yet.... For the comment change, Acked-by: Ping Cheng <pingli...@gmail.com> Thank you Chris, Ping ------------------------------------------------------------------------------ Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more! http://p.sf.net/sfu/dell-eql-dev2dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
