On Fri, Nov 19, 2010 at 1:46 PM, Chris Bagwell <ch...@cnpbagwell.com> wrote:
> On Fri, Nov 19, 2010 at 10:53 AM, Ping Cheng <pingli...@gmail.com> wrote:
>> On Fri, Nov 19, 2010 at 6:16 AM, Chris Bagwell <ch...@cnpbagwell.com> wrote:
>>> On Thu, Nov 18, 2010 at 10:20 PM, <ch...@cnpbagwell.com> wrote:
>>>> From: Chris Bagwell <ch...@cnpbagwell.com>
>>>
>>>> -#define DEFINE_MODEL(mname, identifier, protocol, filter) \
>>>> +#define DEFINE_MODEL(mname, identifier, protocol) \
>>>> static struct _WacomModel mname = \
>>>> { \
>>>> .name = identifier, \
>>>> @@ -75,29 +75,28 @@ static struct _WacomModel mname = \
>>>> .GetRanges = usbWcmGetRanges, \
>>>> .Start = usbStart, \
>>>> .Parse = usbParse, \
>>>> - .FilterRaw = filter, \
>>>> .DetectConfig = usbDetectConfig, \
>>>> };
>>>>
>>>
>>> This part is wrong. I should hardcode to filter name and not delete.
>>>
>>> But do you mind ack/nak'ing though the concept?
>>
>> There was a reason for the difference - not all models that support
>> tilt need tilt filter. Only Inutos series need it. That's why it was
>> called wcmFilterIntuos.
>>
>
> Is that a nak?
It depends.
> You mean you prefer them separate even though the combined version
> takes can of both cases (with and without tilt)?
It is the HANDLE_TILT(common) that makes me feel there is something
else we need to do if we want to combine the two filters. Checking on
the tablet models or something like that inside the routine might be
the way to go.
Ping
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today
http://p.sf.net/sfu/msIE9-sfdev2dev
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
