On Wed, Dec 8, 2010 at 3:06 PM, Peter Hutterer <[email protected]> wrote: > On Wed, Dec 08, 2010 at 08:54:03AM -0800, Ping Cheng wrote: >> On Tue, Dec 7, 2010 at 9:35 PM, Peter Hutterer <[email protected]> >> wrote: >> > Signed-off-by: Peter Hutterer <[email protected]> >> > --- >> > I _think_ this is the correct description for each feature, please check I >> > didn't screw it up. I'm especially not sure about DUALINPUT and ROTATION. >> > >> > src/xf86WacomDefs.h | 22 ++++++++++++---------- >> > 1 files changed, 12 insertions(+), 10 deletions(-) >> > >> > diff --git a/src/xf86WacomDefs.h b/src/xf86WacomDefs.h >> > index 8cdc9e2..d9e374f 100644 >> > --- a/src/xf86WacomDefs.h >> > +++ b/src/xf86WacomDefs.h >> > @@ -118,16 +118,18 @@ struct _WacomModel >> > #define ERASER_ID 0x00000008 >> > #define PAD_ID 0x00000010 >> > >> > -#define WCM_PEN 0x00000001 >> > -#define WCM_TPC 0x00000002 >> > -#define WCM_1FGT 0x00000004 >> > -#define WCM_2FGT 0x00000008 >> > -#define WCM_STRIP 0x00000010 >> > -#define WCM_RING 0x00000020 >> > -#define WCM_DUALINPUT 0x00000040 >> > -#define WCM_ROTATION 0x00000080 >> > -#define WCM_LCD 0x00000100 >> > -#define WCM_PAD 0x00000200 >> > +/* Each tablet may have one or more of the following >> > + * features */ >> > +#define WCM_PEN 0x00000001 /* Tablet supports pens >> > */ >> > +#define WCM_TPC 0x00000002 /* TabletPC (special >> > button handling) */ >> >> TabletPC is a display tablet with special button handling. So, we need >> to make it clear that it has WCM_LCD feature. > > is there any TabletPCs that aren't WCM_LCD too? if so, maybe set WCM_TPC as > 0x02 | WCM_LCD?
All TPCs are LCDs. Ping >> > +#define WCM_1FGT 0x00000004 /* one finger touch */ >> > +#define WCM_2FGT 0x00000008 /* two finger touch */ >> > +#define WCM_STRIP 0x00000010 /* has a scroll strip (e.g. >> > Intuos3) */ >> >> Maybe we want to use the same terms that are used by wacom: >> >> /* Tablet has menu strip(s) (e.g. Intuos3) */ >> >> > +#define WCM_RING 0x00000020 /* has a scroll ring (e.g. >> > Intuos4) */ >> >> /* Tablet has touch ring (e.g. Intuos4) */ >> >> > +#define WCM_DUALINPUT 0x00000040 /* two tools simultaneously >> > (intuos 1 and 2) */ >> >> /* supports two tools on the tablet simultaneously (Intuos 1 and 2) */ >> >> > +#define WCM_ROTATION 0x00000080 /* convert mouse tool tilt to >> > rotation */ >> >> /* needs to convert mouse tool tilt to rotation */ > > > I'll amend the rest, thanks. > > Cheers, > Peter > >> > +#define WCM_LCD 0x00000100 /* Cintiqs and other >> > display tablets */ >> > +#define WCM_PAD 0x00000200 /* has a pad tool */ >> > >> > #define TabletHasFeature(common, feature) (((common)->tablet_type & >> > (feature)) != 0) > ------------------------------------------------------------------------------ This SF Dev2Dev email is sponsored by: WikiLeaks The End of the Free Internet http://p.sf.net/sfu/therealnews-com _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
