My testing result and comments are inline. Ping
On Wed, Dec 15, 2010 at 9:21 PM, Peter Hutterer <[email protected]> wrote: > On Wed, Dec 15, 2010 at 08:50:08PM -0800, Ping Cheng wrote: >> I've tested the set. The ring (I4) is fine except around >> the 0 and 71 area. The strips (I3) still emit unexpected button events >> with single touch (without moving up or down along the strips) >> somehow. I didn't have time to review the patches yet. > > can you specify this a bit? you mean just holding the finger in one > position? It happens not very often. But it happens when touch and leave, or touch and hold. > if so, that'd likely be the filtering logic that I haven't touched in this > set. I do not feel it is a filter issue. I see something in getWheelButton. I think the issue for strips is related to value, stripx/y or oldStripx/y = 0. > need to test the I4 again, didn't notice odd behaviour around the 0-71 switch For wheel/ring, when finger moves across 0 and 71, the direction could be changed since the sign of value = priv->oldWheel - ds->abswheel could be changed. Assume we get abswheel as 34 -> 56 -> 71 -> 2 -> 18, we would get value as: -22, -15, 69, -16. The third one changed from wheeldn to wheelup, which is not what users would expect. There is a compiling warning: CC wcmConfig.lo wcmConfig.c: In function ‘NewWcmPreInit’: wcmConfig.c:515:3: warning: implicit declaration of function ‘asprintf’ wcmConfig.c:515:3: warning: nested extern declaration of ‘asprintf’ CC wcmValidateDevice.lo wcmValidateDevice.c: In function ‘wcmOptionDupConvert’: wcmValidateDevice.c:320:2: warning: implicit declaration of function ‘asprintf’ wcmValidateDevice.c:320:2: warning: nested extern declaration of ‘asprintf’ ------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
