Ok, I see the connection between the two patches. That's why 1/2 is the first ;).
I reviewed patch one again last evening. With the current kernel events reported by wacom_wac, it is fine for both protocols (generic and 4) since we don't send touch data when pen is in prox. If we send both pen and touch data, as in wacom_w8001, I don't think we want to initialize touch with in-prox pen data since touch only shares (x,y) with pen. For example, touch does not have side switches (buttons 2 and 3), while most styli do. If the other tool is out-prox, i.e. only (x,y) is non-zero, it might be ok. I think we need a tool type and in-prox check before initializing the incoming new tool. What do you think? Ping On Tue, Jan 4, 2011 at 6:13 PM, Chris Bagwell <ch...@cnpbagwell.com> wrote: > It's good that you can test other. But please hold off on this patch until > patch 1 is acked. The below bug let's MT bamboo be useable until patch 1 is > submitted. > > Chris > > On Jan 4, 2011, at 7:39 PM, Ping Cheng <pingli...@gmail.com> wrote: > >> On Fri, Dec 31, 2010 at 8:48 PM, <ch...@cnpbagwell.com> wrote: >>> From: Chris Bagwell <ch...@cnpbagwell.com> >>> >>> Somewhere along cleanups, it got switched to looking at wcmKeys >>> instead of abs. This bug though was making tablet usable >>> with MT Bamboo driver until memset() could be removed. >> >> This one is clear to me. But I need time to test the other patch (1/2) >> on protocol 4 (and 5 maybe) devices. It will take sometime. So, I'd >> like to have this patch in first. >> >>> Signed-off-by: Chris Bagwell <ch...@cnpbagwell.com> >> >> Reviewed-by: Ping Cheng <pingli...@gmail.com> >> >> Ping >> >>> --- >>> src/wcmUSB.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/src/wcmUSB.c b/src/wcmUSB.c >>> index faeb3c4..4837c3d 100644 >>> --- a/src/wcmUSB.c >>> +++ b/src/wcmUSB.c >>> @@ -516,7 +516,7 @@ int usbWcmGetRanges(InputInfoPtr pInfo) >>> if (ioctl(pInfo->fd, EVIOCGABS(ABS_DISTANCE), &absinfo) == 0) >>> common->wcmMaxDist = absinfo.maximum; >>> >>> - if (ISBITSET(common->wcmKeys, ABS_MT_SLOT)) >>> + if (ISBITSET(abs, ABS_MT_SLOT)) >>> private->wcmUseMT = 1; >>> >>> /* A generic protocol device does not report ABS_MISC event */ >>> -- >>> 1.7.3.4 >>> >>> >>> ------------------------------------------------------------------------------ >>> Learn how Oracle Real Application Clusters (RAC) One Node allows customers >>> to consolidate database storage, standardize their database environment, >>> and, >>> should the need arise, upgrade to a full multi-node Oracle RAC database >>> without downtime or disruption >>> http://p.sf.net/sfu/oracle-sfdevnl >>> _______________________________________________ >>> Linuxwacom-devel mailing list >>> Linuxwacom-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel >>> > ------------------------------------------------------------------------------ Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
