One last item for the night. The reason touch cursor totally stops
moving is related to removing code that set maxWidth/maxHeight but its
still referenced for relative devices (the commit mentioned below
removed it). Following patch gets back to jumpy cursor but is
obviously wrong:
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
index 516d57c..d8a7890 100644
--- a/src/wcmCommon.c
+++ b/src/wcmCommon.c
@@ -98,6 +98,9 @@ void wcmMappingFactor(InputInfoPtr pInfo)
priv->bottomX, priv->bottomY, priv->sizeX, priv->sizeY,
priv->maxWidth, priv->maxHeight);
+ /* FIXME */
+ priv->maxWidth = priv->maxX;
+ priv->maxHeight = priv->maxY;
priv->factorX = (double)priv->maxWidth / (double)priv->sizeX;
priv->factorY = (double)priv->maxHeight / (double)priv->sizeY;
DBG(2, priv, "X factor = %.3g, Y factor = %.3g\n",
I'm taking a guess if we set X/Y axis min/max values to something
besides -1 then wcmRotateAndScale() will cure jumpyness.... but just a
guess right now.
Also, a third issue is device_type is being set to a value of 4 and
causing wcmSendEvents() to discard events from unknown device. It can
be worked around by touching with 2 fingers. Something about 2
touches sets device_type correctly and then even 1 finger works from
then on (with above patch that is and is jumpy).
I'll work on device_type being mis-set for sure but I'm hoping for at
least guidance from Peter on the relative delta logic.
Chris
On Mon, Jan 10, 2011 at 8:50 PM, Chris Bagwell <ch...@cnpbagwell.com> wrote:
> OK, probably last email of the night. I notice this in xinput output
> in patch were its good.
>
> Label: Abs X
> Range: 0.000000 - 15360.000000
> Resolution: 0 units/m
> Mode: relative
>
> And it changes to this in the first patch were it goes bad:
>
> Label: Abs X
> Range: -1.000000 - -1.000000
> Resolution: 0 units/m
> Mode: relative
>
> So I'm going to take a wild guess it may be related to how we are
> calculating delta. Its not as simple as changing the ranges back to
> old values. I tried that... Next up is looking at what we are
> calculating.
>
> Chris
>
> On Mon, Jan 10, 2011 at 7:20 PM, Chris Bagwell <ch...@cnpbagwell.com> wrote:
>> Here is what my bisect turns up:
>>
>> At this commit, the cursor becomes overly accelerated or jumpy:
>>
>> 1e4d3d7060a1c438ac619cb64febb44bc45b47ed
>> Remove wcmInitialCoordiantes, move into wcmInitAxes
>>
>> At this commit, it always slams into left wall:
>>
>> 6f5f29b49a6ebda7ae13ca9c32e6e16cf3181fc2
>> Purge screen coordinate storage
>>
>> I may have got jumpy vs. left wall wrong but it should correct that
>> patches before "Purge screen.." have reasonable cursor movement on
>> touch device (not tested extensively).
>>
>> No obvious reason why when looking at diff so sending to mailing list for
>> input.
>>
>> Chris
>>
>> On Mon, Jan 10, 2011 at 2:22 AM, Favux ... <favux...@gmail.com> wrote:
>>> Hi Peter,
>>>
>>> Bisection shows it is the 12-21-10 "Merge branch 'multimonitor-purge'"
>>> commit. Its snapshot xf86-input-wacom-68351da breaks touch. Although
>>> rather than slamming to the left it jitters horizontally in place over
>>> about 1.5 cm. The prior commit of the same date "Bamboo tablet does
>>> not report device_id anymore" snapshot xf86-input-wacom-2b9eb3d still
>>> has working touch.
>>>
>>> Favux
>>>
>>> On Sun, Jan 9, 2011 at 11:53 PM, Peter Hutterer
>>> <peter.hutte...@who-t.net> wrote:
>>>>
>>>> can you run a bisect over the code to identify which commit broke it?
>>>> three different features got merged, multimonitor removal, the scrollring
>>>> fixes and chris' bamboo patches. Not sure which one caused the bug.
>>>>
>>>> Cheers,
>>>> Peter
>>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Gaining the trust of online customers is vital for the success of any
>>> company
>>> that requires sensitive data to be transmitted over the Web. Learn how to
>>> best implement a security strategy that keeps consumers' information secure
>>> and instills the confidence they need to proceed with transactions.
>>> http://p.sf.net/sfu/oracle-sfdevnl
>>> _______________________________________________
>>> Linuxwacom-devel mailing list
>>> Linuxwacom-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
>>>
>>
>
------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web. Learn how to
best implement a security strategy that keeps consumers' information secure
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
