Reviewed-by: Chris Bagwell <ch...@cnpbagwell.com>
On a related note, several of the *Default variables can probably be
converted to constants (#defines). It seems only useful as a variable
for cases were there is a hardware specific default value.
This variable may one day be that case. I can see how default should
be calculated based "this_device_x_range * (250 / BAMBOO_X_RANGE)"
instead of hardcoded to 250. But if I recall, we do not populate
min/max until after below logic executes so that would have to be
solved first.
Chris
On Mon, Jan 10, 2011 at 8:08 PM, Peter Hutterer
<peter.hutte...@who-t.net> wrote:
> Overwriting the default option with the same value doesn't seem to be
> useful. Also add a fixme, this code shouldn't be here in the first place.
>
> Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
> ---
> src/wcmValidateDevice.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c
> index 4b51596..bd594fb 100644
> --- a/src/wcmValidateDevice.c
> +++ b/src/wcmValidateDevice.c
> @@ -697,12 +697,12 @@ int wcmParseOptions(InputInfoPtr pInfo, int hotplugged)
> xf86Msg(X_WARNING, "%s: Touch gesture option can only "
> "be set by a touch tool.\n", pInfo->name);
>
> + /* FIXME: wtf is this here?? */
> if ((common->wcmDevCls == &gWacomUSBDevice) &&
> TabletHasFeature(common, WCM_LCD) &&
> TabletHasFeature(common, WCM_2FGT)) {
> common->wcmGestureParameters.wcmZoomDistanceDefault =
> 30;
> common->wcmGestureParameters.wcmScrollDistanceDefault
> = 30;
> - common->wcmGestureParameters.wcmTapTimeDefault = 250;
> }
>
> common->wcmGestureParameters.wcmZoomDistance =
> --
> 1.7.3.4
>
> ------------------------------------------------------------------------------
> Gaining the trust of online customers is vital for the success of any company
> that requires sensitive data to be transmitted over the Web. Learn how to
> best implement a security strategy that keeps consumers' information secure
> and instills the confidence they need to proceed with transactions.
> http://p.sf.net/sfu/oracle-sfdevnl
> _______________________________________________
> Linuxwacom-devel mailing list
> Linuxwacom-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
>
------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
