On Tue, Jan 11, 2011 at 10:12 PM, Ping Cheng <pingli...@gmail.com> wrote: > On Tue, Jan 11, 2011 at 8:07 PM, Chris Bagwell <ch...@cnpbagwell.com> wrote: >> On Tue, Jan 11, 2011 at 10:03 PM, Ping Cheng <pingli...@gmail.com> wrote: >>> On Tue, Jan 11, 2011 at 5:34 PM, <ch...@cnpbagwell.com> wrote: >>>> From: Chris Bagwell <ch...@cnpbagwell.com> >>>> >>>> A previous commit removed all bamboo ID's which caused it >>>> to hit default statement removed in this patch and mistakenly >>>> add WCM_PEN for Bamboo touchpad. >>>> >>>> That flag only seems to be used by a debug statement so not >>>> a big deal unless you want that information out of log file. >>>> >>>> Change to generically set WCM_PEN feature based only on existence >>>> of BTN_TOOL_PEN so all PEN enabled tablets will declare that >>>> feature; which seems the conceptially correct thing to do >>>> and has side affect of getting debug statement working for >>>> Bamboo's again. >>>> >>>> Signed-off-by: Chris Bagwell <ch...@cnpbagwell.com> >>> >>> Acked-by: Ping Cheng <pingli...@gmail.com> >> >> Thanks. >> >>> >>> Recent changes related to wcmDeviceTypeKeys would most likely break >>> wcmISDV4.c. I'll fix it when I have time. >> >> Hmmm, looked like it would work as best I could tell from review but >> hard to know without a real device to test. Thanks for looking into >> it. > > Serial devices don't have BTN_TOOL_* set. We tell the device > types/features by its id. >
It does a small amount of fake key setting in set_keybits_*()... enough to get touch detection to work I think... and I think it must originally be to get hotplug just working enough. All in all, there is room for bugs to be found in this area. Chris ------------------------------------------------------------------------------ Protect Your Site and Customers from Malware Attacks Learn about various malware tactics and how to avoid them. Understand malware threats, the impact they can have on your business, and how you can protect your company and customers by using code signing. http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
