Hi Andrzej, Thank you for the patches. Please see my comments inline.
Ping On Mon, Jan 10, 2011 at 10:20 AM, Andrzej Pronobis <a.prono...@gmail.com> wrote: > Hi, > > I would like to contribute two patches against the current git master. > Both patches are related to scroll/zoom gestures and were tested on a > serial Wacom tablet in Lenovo X201t. > The first patch is described in the following tracker issue: > http://goo.gl/pyhax > " > A patch fixing the delay previously required before the scroll or zoom > gestures. The patch implements the following behavior: > - two fingers enable the zoom/scroll gestures immediately without any > additional delay or lagging Please explain how to decide if the gesture is a zooming or scrolling without waiting to understand which direction the two fingers are moving. > - quick tap using the second finger emits right click > - right click now does not emit left click at the same time Don't we lose the right click functions if we send left click after right click? For instance, when cursor is on a winodw's title bar, a quick tap emits a right click which opens a dropdown menu. If we send left clcik after the right click, it closes the menu. That's not what we want, it it? When cursor is on the desktop not on any icons or windows, without sending the left click up, the right click can not open the dropdown menu that we are expecting. Am I testing something different from yours? > The second patch fixes the bug with gestures not being rotated > properly when the orientation of the tablet is changed using the > "Rotate" xsetwacom param. This one is sensible. Please add Signed-off-by: Andrzej Pronobis <a.prono...@gmail.com> and Reviewed-by: Ping Cheng <pingli...@gmail.com> to the patch. Submit it to the list and cc to Peter so he can merge it. Thank you. Ping ------------------------------------------------------------------------------ Protect Your Site and Customers from Malware Attacks Learn about various malware tactics and how to avoid them. Understand malware threats, the impact they can have on your business, and how you can protect your company and customers by using code signing. http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
